From: Shlomo Pongartz <shlomop@mellanox•com>
To: Or Gerlitz <or.gerlitz@gmail•com>
Cc: David Miller <davem@davemloft•net>, <klebers@linux•vnet.ibm.com>,
<netdev@vger•kernel.org>, <jackm@dev•mellanox.co.il>,
<yevgenyp@mellanox•co.il>, <ogerlitz@mellanox•com>,
<cascardo@linux•vnet.ibm.com>, <brking@linux•vnet.ibm.com>
Subject: Re: [PATCH] mlx4: Add support for EEH error recovery
Date: Wed, 25 Jul 2012 17:38:22 +0300 [thread overview]
Message-ID: <501004DE.6050300@mellanox.com> (raw)
In-Reply-To: <CAJZOPZKUw7DQQH5mFq4XK5GOZ_Wj6JmjFYi6no7aL_UrpO10vw@mail.gmail.com>
On 7/25/2012 1:30 AM, Or Gerlitz wrote:
> On Wed, Jul 25, 2012 at 12:03 AM, David Miller <davem@davemloft•net> wrote:
>
>> Or, you promised an ACK today, I still haven't seen it.
> It turned out that reacted we did, but not the ACK way.
>
> Again, code review wise, we intended to ack it, but Shlomo has set
> testing environment, under which he had some issues with the patch, as
> such he preferred not to ACK it but rather bring up the issues on the
> list and sort them out 1st. I thought it would be wrong to over-rule
> this preference of him, and this way is fair-enough with the author
> and your guide-lines, maybe I had to be more aggressive with ACKing
> this, as of the merge window closing coming. So tomorrow.
>
> Or.
>
>> There is no reason Kleber should be penalized and have his work
>> miss the merge window just because you guys can't be bothered
>> to approve this patch in a reasonable amount of time.
>>
>> Therefore I'm just going to apply it later today, and don't do this
>> with someone's submission ever again, it impedes progress and
>> frustrates contributors.
> .
>
The code looks fine and can be merged.
We will continue to test it under various conditions.
Sorry for the delay.
Thank you.
Shlomo Pongratz.
next prev parent reply other threads:[~2012-07-25 14:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 19:55 [PATCH] mlx4: Add support for EEH error recovery Kleber Sacilotto de Souza
2012-07-22 10:29 ` Or Gerlitz
[not found] ` <500BD558.2060803@mellanox.com>
2012-07-23 0:15 ` David Miller
2012-07-23 13:18 ` Kleber Sacilotto de Souza
2012-07-23 13:45 ` Or Gerlitz
2012-07-23 18:12 ` Kleber Sacilotto de Souza
2012-07-23 20:53 ` Kleber Sacilotto de Souza
2012-07-23 21:26 ` Or Gerlitz
2012-07-23 21:34 ` David Miller
2012-07-23 21:42 ` Or Gerlitz
2012-07-23 21:44 ` David Miller
2012-07-23 22:02 ` Or Gerlitz
2012-07-23 22:21 ` David Miller
2012-07-24 13:12 ` Kleber Sacilotto de Souza
2012-07-24 17:09 ` Shlomo Pongartz
2012-07-24 17:35 ` Kleber Sacilotto de Souza
2012-07-24 18:08 ` Thadeu Lima de Souza Cascardo
2012-07-24 18:35 ` Shlomo Pongratz
2012-07-24 18:39 ` Shlomo Pongratz
2012-07-24 21:03 ` David Miller
2012-07-24 22:30 ` Or Gerlitz
2012-07-25 14:38 ` Shlomo Pongartz [this message]
[not found] ` <5010070B.5040405@mellanox.com>
2012-07-25 15:02 ` Kleber Sacilotto de Souza
2012-07-25 22:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501004DE.6050300@mellanox.com \
--to=shlomop@mellanox$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=cascardo@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=jackm@dev$(echo .)mellanox.co.il \
--cc=klebers@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=or.gerlitz@gmail$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox