From: Stefan Roese <sr@denx•de>
To: Arnd Bergmann <arnd@arndb•de>
Cc: linux-arm-kernel@lists•infradead.org, arm@kernel•org,
linux-kernel@vger•kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH 07/11] net/stmmac: mark probe function as __devinit
Date: Wed, 08 Aug 2012 17:07:21 +0200 [thread overview]
Message-ID: <502280A9.5070009@denx.de> (raw)
In-Reply-To: <1344437248-20560-8-git-send-email-arnd@arndb.de>
On 08/08/2012 04:47 PM, Arnd Bergmann wrote:
> Driver probe functions are generally __devinit so they will be
> discarded after initialization for non-hotplug kernels.
> This was found by a new warning after patch 6a228452d "stmmac: Add
> device-tree support" adds a new __devinit function that is called
> from stmmac_pltfr_probe.
>
> Without this patch, building socfpga_defconfig results in:
>
> WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
> The function stmmac_pltfr_probe() references
> the function __devinit stmmac_probe_config_dt().
> This is often because stmmac_pltfr_probe lacks a __devinit
> annotation or the annotation of stmmac_probe_config_dt is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Cc: Stefan Roese <sr@denx•de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
> Cc: David S. Miller <davem@davemloft•net>
> Cc: netdev@vger•kernel.org
Acked-by: Stefan Roese <sr@denx•de>
Thanks,
Stefan
next prev parent reply other threads:[~2012-08-08 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 14:47 [PATCH 00/11] recently added ARM defconfig warnings Arnd Bergmann
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
2012-08-08 15:07 ` Stefan Roese [this message]
2012-08-08 23:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502280A9.5070009@denx.de \
--to=sr@denx$(echo .)de \
--cc=arm@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox