* [PATCH 00/11] recently added ARM defconfig warnings
@ 2012-08-08 14:47 Arnd Bergmann
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2012-08-08 14:47 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Takashi Iwai, Linus Walleij, Grant Likely, Laxman Dewangan,
Philipp Zabel, Giuseppe Cavallaro, Stefan Roese, Lee Jones,
Kukjin Kim, Vincent Guittot, Samuel Ortiz, arm, Alan Stern,
Grazvydas Ignotas, Paul Parsons, Russell King, Peter Zijlstra,
Arnd Bergmann, Thomas Abraham, Rafael J. Wysocki, Jaswinder Singh,
Magnus Damm, Namhyung Kim, Greg
These patches address problems that showed up in new warnings
when building all ARM defconfig files in v3.6-rc1 compared
with v3.5.
I can merge them through the arm-soc tree or have subsystem
maintainers pick them up if they prefer.
Arnd Bergmann (11):
ARM: topology: mark init_cpu_topology as __init
mfd/asic3: fix asic3_mfd_probe return value
usb/ohci-omap: remove unused variable
ARM: ux500: really kill snowball_of_platform_devs
ARM: exynos: exynos_pm_add_dev_to_genpd may be unused
gpio: em: do not discard em_gio_irq_domain_cleanup
net/stmmac: mark probe function as __devinit
mtd/omap2: fix dmaengine_slave_config error handling
regulator/twl: remove fixed resource handling
spi/s3c64xx: improve error handling
pm/drivers: fix use of SIMPLE_DEV_PM_OPS
Cc: Alan Stern <stern@rowland•harvard.edu>
Cc: David S. Miller <davem@davemloft•net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
Cc: Grant Likely <grant.likely@secretlab•ca>
Cc: Grazvydas Ignotas <notasas@gmail•com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: Jaswinder Singh <jaswinder.singh@linaro•org>
Cc: Kukjin Kim <kgene.kim@samsung•com>
Cc: Laxman Dewangan <ldewangan@nvidia•com>
Cc: Lee Jones <lee.jones@linaro•org>
Cc: Linus Walleij <linus.walleij@linaro•org>
Cc: Magnus Damm <damm@opensource•se>
Cc: Mark Brown <broonie@opensource•wolfsonmicro.com>
Cc: Namhyung Kim <namhyung@kernel•org>
Cc: Paul Parsons <lost.distance@yahoo•com>
Cc: Peter Zijlstra <a.p.zijlstra@chello•nl>
Cc: Philipp Zabel <philipp.zabel@gmail•com>
Cc: Rafael J. Wysocki <rjw@sisk•pl>
Cc: Richard Zhao <richard.zhao@freescale•com>
Cc: Russell King <rmk+kernel@arm•linux.org.uk>
Cc: Samuel Ortiz <sameo@linux•intel.com>
Cc: Stefan Roese <sr@denx•de>
Cc: Takashi Iwai <tiwai@suse•de>
Cc: Thomas Abraham <thomas.abraham@linaro•org>
Cc: Vincent Guittot <vincent.guittot@linaro•org>
Cc: netdev@vger•kernel.org
arch/arm/kernel/topology.c | 2 +-
arch/arm/mach-exynos/pm_domains.c | 2 +-
arch/arm/mach-ux500/board-mop500.c | 5 -----
drivers/char/hw_random/omap-rng.c | 2 +-
drivers/gpio/gpio-em.c | 2 +-
drivers/i2c/busses/i2c-tegra.c | 2 +-
drivers/mfd/asic3.c | 1 +
drivers/mtd/nand/omap2.c | 7 +++----
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
drivers/regulator/twl-regulator.c | 21 --------------------
drivers/spi/spi-s3c64xx.c | 2 +-
drivers/usb/host/ohci-omap.c | 2 --
sound/drivers/dummy.c | 2 +-
13 files changed, 12 insertions(+), 40 deletions(-)
--
1.7.10
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 07/11] net/stmmac: mark probe function as __devinit
2012-08-08 14:47 [PATCH 00/11] recently added ARM defconfig warnings Arnd Bergmann
@ 2012-08-08 14:47 ` Arnd Bergmann
2012-08-08 15:07 ` Stefan Roese
2012-08-08 23:08 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2012-08-08 14:47 UTC (permalink / raw)
To: linux-arm-kernel
Cc: arm, linux-kernel, Arnd Bergmann, Stefan Roese,
Giuseppe Cavallaro, David S. Miller, netdev
Driver probe functions are generally __devinit so they will be
discarded after initialization for non-hotplug kernels.
This was found by a new warning after patch 6a228452d "stmmac: Add
device-tree support" adds a new __devinit function that is called
from stmmac_pltfr_probe.
Without this patch, building socfpga_defconfig results in:
WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
The function stmmac_pltfr_probe() references
the function __devinit stmmac_probe_config_dt().
This is often because stmmac_pltfr_probe lacks a __devinit
annotation or the annotation of stmmac_probe_config_dt is wrong.
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Cc: Stefan Roese <sr@denx•de>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
Cc: David S. Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index cd01ee7..b93245c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -74,7 +74,7 @@ static int __devinit stmmac_probe_config_dt(struct platform_device *pdev,
* the necessary resources and invokes the main to init
* the net device, register the mdio bus etc.
*/
-static int stmmac_pltfr_probe(struct platform_device *pdev)
+static int __devinit stmmac_pltfr_probe(struct platform_device *pdev)
{
int ret = 0;
struct resource *res;
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 07/11] net/stmmac: mark probe function as __devinit
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
@ 2012-08-08 15:07 ` Stefan Roese
2012-08-08 23:08 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2012-08-08 15:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, arm, linux-kernel, Giuseppe Cavallaro,
David S. Miller, netdev
On 08/08/2012 04:47 PM, Arnd Bergmann wrote:
> Driver probe functions are generally __devinit so they will be
> discarded after initialization for non-hotplug kernels.
> This was found by a new warning after patch 6a228452d "stmmac: Add
> device-tree support" adds a new __devinit function that is called
> from stmmac_pltfr_probe.
>
> Without this patch, building socfpga_defconfig results in:
>
> WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
> The function stmmac_pltfr_probe() references
> the function __devinit stmmac_probe_config_dt().
> This is often because stmmac_pltfr_probe lacks a __devinit
> annotation or the annotation of stmmac_probe_config_dt is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Cc: Stefan Roese <sr@denx•de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
> Cc: David S. Miller <davem@davemloft•net>
> Cc: netdev@vger•kernel.org
Acked-by: Stefan Roese <sr@denx•de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 07/11] net/stmmac: mark probe function as __devinit
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
2012-08-08 15:07 ` Stefan Roese
@ 2012-08-08 23:08 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-08-08 23:08 UTC (permalink / raw)
To: arnd; +Cc: linux-arm-kernel, arm, linux-kernel, sr, peppe.cavallaro, netdev
From: Arnd Bergmann <arnd@arndb•de>
Date: Wed, 8 Aug 2012 16:47:24 +0200
> Driver probe functions are generally __devinit so they will be
> discarded after initialization for non-hotplug kernels.
> This was found by a new warning after patch 6a228452d "stmmac: Add
> device-tree support" adds a new __devinit function that is called
> from stmmac_pltfr_probe.
>
> Without this patch, building socfpga_defconfig results in:
>
> WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
> The function stmmac_pltfr_probe() references
> the function __devinit stmmac_probe_config_dt().
> This is often because stmmac_pltfr_probe lacks a __devinit
> annotation or the annotation of stmmac_probe_config_dt is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Cc: Stefan Roese <sr@denx•de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
> Cc: David S. Miller <davem@davemloft•net>
> Cc: netdev@vger•kernel.org
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-08 23:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-08 14:47 [PATCH 00/11] recently added ARM defconfig warnings Arnd Bergmann
2012-08-08 14:47 ` [PATCH 07/11] net/stmmac: mark probe function as __devinit Arnd Bergmann
2012-08-08 15:07 ` Stefan Roese
2012-08-08 23:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox