From: Or Gerlitz <ogerlitz@mellanox•com>
To: <davem@davemloft•net>, <roland@kernel•org>
Cc: <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB
Date: Wed, 29 Aug 2012 12:41:00 +0300 [thread overview]
Message-ID: <503DE3AC.30701@mellanox.com> (raw)
In-Reply-To: <1345724119-32110-1-git-send-email-ogerlitz@mellanox.com>
On 23/08/2012 15:15, Or Gerlitz wrote:
> This is about adding rtnl_link_ops to IPoIB, primarly addressing feedback from Dave on a similar patch that was part of the eIPoIB submission.
Dave, Roland
Any comment on this? The patch was originally submitted through netdev
so I kept the fixed version to go through that path as well. If this
makes things easier, we can merge that through net-next.
IPoIB has more proprietary sysfs entries, such as for setting the mode
(datagram or connected) -- in 2nd thought, non legacy ipoib child
interfaces created through rtnl shouldn't preserve these prop.
mechanisms and use rtnl for all sorts of configs, as done for
macvlan/8021q etc devices, correct? if this is indeed the case, I will
fix that and submit V3.
Or.
>
> Also added the releated iproute2 patch, for the sake of the review and
> testing, e.g example usages:
>
> $ ip link add link ib0 name ib0.1 type ipoib
> $ ip link add link ib0 name ib0.8001 type ipoib pkey 0x8001
>
> and the obvious
>
> $ link delete dev ib0.8001
> $ link delete dev ib0.1
>
> Changes from V2:
> - removed the notion of user defined index per child, since we can do well w.o it
> - for that end, make (an internal to ipoib) distrinction between legacy childs created
> through the old sysfs way to childs created using rtnl link ops
>
> Changes from V1:
> - applied feedback from Dave Miller to avoid using sysfs
> - added rtnl_link_ops support in ipoib and use them to add/delete childs
>
> Or Gerlitz (1):
> IB/ipoib: Add rtnl_link_ops support
>
> Documentation/infiniband/ipoib.txt | 3 +
> drivers/infiniband/ulp/ipoib/Makefile | 3 +-
> drivers/infiniband/ulp/ipoib/ipoib.h | 13 +++
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 25 ++++-
> drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 122 ++++++++++++++++++++++++++
> drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 102 ++++++++++++----------
> 6 files changed, 217 insertions(+), 51 deletions(-)
> create mode 100644 drivers/infiniband/ulp/ipoib/ipoib_netlink.c
>
next prev parent reply other threads:[~2012-08-29 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:15 [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB Or Gerlitz
2012-08-23 12:15 ` [PATCH net-next V3 1/2] IB/ipoib: Add rtnl_link_ops support Or Gerlitz
2012-08-29 12:53 ` Patrick McHardy
2012-08-29 12:59 ` Or Gerlitz
2012-09-12 10:40 ` Or Gerlitz
2012-09-12 14:53 ` Rami Rosen
2012-09-12 15:13 ` Eric Dumazet
2012-09-13 10:54 ` Or Gerlitz
2012-09-13 11:28 ` Or Gerlitz
2012-08-23 12:15 ` [PATCH iproute2 2/2] iplink: added support for ipoib rtnl link ops Or Gerlitz
2012-09-04 17:48 ` Stephen Hemminger
2012-09-04 18:35 ` Or Gerlitz
2012-08-29 9:41 ` Or Gerlitz [this message]
2012-08-29 12:45 ` [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503DE3AC.30701@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roland@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox