From: Or Gerlitz <ogerlitz@mellanox•com>
To: Rami Rosen <roszenrami@gmail•com>
Cc: Patrick McHardy <kaber@trash•net>,
Eric Dumazet <eric.dumazet@gmail•com>, <netdev@vger•kernel.org>,
Shlomo Pongratz <shlomop@mellanox•com>
Subject: Re: [PATCH net-next V3 1/2] IB/ipoib: Add rtnl_link_ops support
Date: Thu, 13 Sep 2012 14:28:35 +0300 [thread overview]
Message-ID: <5051C363.7030505@mellanox.com> (raw)
In-Reply-To: <CAKoUAr=8zZA9EgvJEVrd0a-Uw=zzksHj+5P2Sp3Lb4vXgSJRYA@mail.gmail.com>
On 12/09/2012 17:53, Rami Rosen wrote:
> From the dump of CPU #1, it seems indeed not related at all to "modprobe -r".
>
> Could it be that there is some IB stack sysfs write activity?
> (regardless of the modprobe -r" you issued) ? I see some candidates for it.
>
> delete_child() is a method of the IB stack (ipoib/ipoib_main.c)
>
> Maybe in order to help debug the problem, you might try to add in
> delete_child() method, print of the name of the attribute which is being deleted?
>
> (struct device_attribute has a a member "struct attribute attr",
> which in turn has "const char *name").
>
> the existing dependency chain (in reverse order) is:
>
> -> #1 (rtnl_mutex){+.+.+.}:
> [<ffffffff81072b30>] lock_acquire+0x14f/0x19b
> [<ffffffff81396a43>] mutex_lock_nested+0x64/0x2ce
> [<ffffffff812fc103>] rtnl_lock+0x12/0x14
> [<ffffffff812eecf1>] netdev_run_todo+0xa5/0x27e
> [<ffffffff812fc0dd>] rtnl_unlock+0x9/0xb
> [<ffffffffa0394889>] ipoib_vlan_delete+0x111/0x148 [ib_ipoib]
> [<ffffffffa038d29b>] delete_child+0x44/0x60 [ib_ipoib]
> [<ffffffff81247bd8>] dev_attr_store+0x1b/0x1d
> [<ffffffff8114e223>] sysfs_write_file+0x103/0x13f
> [<ffffffff810f206b>] vfs_write+0xae/0x133
> [<ffffffff810f21a9>] sys_write+0x45/0x6c
> [<ffffffff813a05e2>] system_call_fastpath+0x16/0x1b
I've added code in ipoib_delete_child to print the caller PID and dump
the stack,
its triggeredwhen I do "echo 0x8001 > /sys/class/net/ib0/delete_child"
but the lockdep
warningis raised only when I actually unload the module, and no print...
that is
ipoib_delete_child isn't called.
Or.
next prev parent reply other threads:[~2012-09-13 11:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:15 [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB Or Gerlitz
2012-08-23 12:15 ` [PATCH net-next V3 1/2] IB/ipoib: Add rtnl_link_ops support Or Gerlitz
2012-08-29 12:53 ` Patrick McHardy
2012-08-29 12:59 ` Or Gerlitz
2012-09-12 10:40 ` Or Gerlitz
2012-09-12 14:53 ` Rami Rosen
2012-09-12 15:13 ` Eric Dumazet
2012-09-13 10:54 ` Or Gerlitz
2012-09-13 11:28 ` Or Gerlitz [this message]
2012-08-23 12:15 ` [PATCH iproute2 2/2] iplink: added support for ipoib rtnl link ops Or Gerlitz
2012-09-04 17:48 ` Stephen Hemminger
2012-09-04 18:35 ` Or Gerlitz
2012-08-29 9:41 ` [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB Or Gerlitz
2012-08-29 12:45 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051C363.7030505@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roszenrami@gmail$(echo .)com \
--cc=shlomop@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox