From: Chris Friesen <chris.friesen@genband•com>
To: Ying Xue <ying.xue@windriver•com>
Cc: netdev <netdev@vger•kernel.org>,
Allan Stephens <allan.stephens@windriver•com>,
Jon Maloy <jon.maloy@ericsson•com>
Subject: Re: [BUG] TIPC handling of -ERESTARTSYS in connect()
Date: Fri, 31 Aug 2012 09:09:56 -0600 [thread overview]
Message-ID: <5040D3C4.2010308@genband.com> (raw)
In-Reply-To: <504085D9.3010907@windriver.com>
On 08/31/2012 03:37 AM, Ying Xue wrote:
> Hi Chris,
>
> Although this is a known issue, still thanks for your report.
>
> Regardless of 1.7.7 or mainline, the issue really exists.
> Can you please check and verify the attached patch?
>
> PS: the patch is based on 1.7.7 rather than mainline.
I haven't had a chance to test it yet but from visual inspection the
patch looks pretty good.
It looks like the case where we come in with "sock->state ==
SS_LISTENING" has changed. Previously we would return -EOPNOTSUPP but
now it'll be -EINVAL. Is that intentional?
Chris
next prev parent reply other threads:[~2012-08-31 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 15:20 [BUG] TIPC handling of -ERESTARTSYS in connect() Chris Friesen
2012-08-31 9:37 ` Ying Xue
2012-08-31 15:09 ` Chris Friesen [this message]
2012-08-31 15:18 ` Chris Friesen
2012-09-03 3:16 ` Ying Xue
2012-09-04 14:54 ` Chris Friesen
2012-10-31 23:01 ` Chris Friesen
2012-11-01 6:35 ` Xue Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040D3C4.2010308@genband.com \
--to=chris.friesen@genband$(echo .)com \
--cc=allan.stephens@windriver$(echo .)com \
--cc=jon.maloy@ericsson$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox