From: Chris Friesen <chris.friesen@genband•com>
To: Ying Xue <ying.xue@windriver•com>
Cc: netdev <netdev@vger•kernel.org>,
Allan Stephens <allan.stephens@windriver•com>,
Jon Maloy <jon.maloy@ericsson•com>
Subject: Re: [BUG] TIPC handling of -ERESTARTSYS in connect()
Date: Wed, 31 Oct 2012 17:01:26 -0600 [thread overview]
Message-ID: <5091ADC6.4000307@genband.com> (raw)
In-Reply-To: <5046161F.8070703@genband.com>
On 09/04/2012 08:54 AM, Chris Friesen wrote:
> On 09/02/2012 09:16 PM, Ying Xue wrote:
>>
>>>>
>>>> It looks like the case where we come in with "sock->state ==
>>>> SS_LISTENING" has changed. Previously we would return -EOPNOTSUPP but
>>>> now it'll be -EINVAL. Is that intentional?
>>>
>>> Just noticed something else. In the SS_CONNECTING case I don't think
>>> there's any point in setting "res = -EALREADY" since a bit further
>>> down it gets set unconditionally anyway.
>>>
>> Yes, you are right. Please check v2 version.
>
> Looks good to me. Still haven't had a chance to actually test it though,
> we're pushing out a release and time is scarce.
I finally got a chance to test this out, and it does indeed fix the
problem. Please push it upstream.
Tested-by: Chris Friesen <chris.friesen@genband•com>
Chris
next prev parent reply other threads:[~2012-10-31 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 15:20 [BUG] TIPC handling of -ERESTARTSYS in connect() Chris Friesen
2012-08-31 9:37 ` Ying Xue
2012-08-31 15:09 ` Chris Friesen
2012-08-31 15:18 ` Chris Friesen
2012-09-03 3:16 ` Ying Xue
2012-09-04 14:54 ` Chris Friesen
2012-10-31 23:01 ` Chris Friesen [this message]
2012-11-01 6:35 ` Xue Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5091ADC6.4000307@genband.com \
--to=chris.friesen@genband$(echo .)com \
--cc=allan.stephens@windriver$(echo .)com \
--cc=jon.maloy@ericsson$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox