* [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
@ 2012-11-05 11:17 Chen Gang
2012-11-06 1:11 ` Chen Gang
2012-11-06 1:13 ` Chen Gang
0 siblings, 2 replies; 9+ messages in thread
From: Chen Gang @ 2012-11-05 11:17 UTC (permalink / raw)
To: David Miller, kuznet, jmorris, yoshfuji, kaber; +Cc: netdev
the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
so change it to %s, since each line has not been solid any more.
Signed-off-by: Chen Gang <gang.chen@asianux•com>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8f0b12a..9f728a8 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
void *v)
static int if6_seq_show(struct seq_file *seq, void *v)
{
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
&ifp->addr,
ifp->idev->dev->ifindex,
ifp->prefix_len,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-05 11:17 [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop Chen Gang
@ 2012-11-06 1:11 ` Chen Gang
2012-11-06 1:42 ` Shan Wei
2012-11-06 1:13 ` Chen Gang
1 sibling, 1 reply; 9+ messages in thread
From: Chen Gang @ 2012-11-06 1:11 UTC (permalink / raw)
To: David Miller, kuznet, jmorris, yoshfuji, kaber; +Cc: netdev
于 2012年11月05日 19:17, Chen Gang 写道:
>
> the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
> in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
> so change it to %s, since each line has not been solid any more.
>
1) sorry, the comments is incorrect
need use ifp->idev->dev->name instead of rt->dst.dev->name in 2nd line.
I will send it again.
2) By the way, the three patches "* %8s to %s *" are almost the same
If need merge them into one patch, please tell me, I shall do.
thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-05 11:17 [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop Chen Gang
2012-11-06 1:11 ` Chen Gang
@ 2012-11-06 1:13 ` Chen Gang
2012-11-06 1:21 ` Eric Dumazet
2012-11-06 1:29 ` [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_show Chen Gang
1 sibling, 2 replies; 9+ messages in thread
From: Chen Gang @ 2012-11-06 1:13 UTC (permalink / raw)
To: David Miller, kuznet, jmorris, yoshfuji, kaber; +Cc: netdev
the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for ifp->idev->dev->name.
so change it to %s, since each line has not been solid any more.
Signed-off-by: Chen Gang <gang.chen@asianux•com>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8f0b12a..9f728a8 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
void *v)
static int if6_seq_show(struct seq_file *seq, void *v)
{
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
&ifp->addr,
ifp->idev->dev->ifindex,
ifp->prefix_len,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-06 1:13 ` Chen Gang
@ 2012-11-06 1:21 ` Eric Dumazet
2012-11-06 1:26 ` Chen Gang
2012-11-06 1:29 ` [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_show Chen Gang
1 sibling, 1 reply; 9+ messages in thread
From: Eric Dumazet @ 2012-11-06 1:21 UTC (permalink / raw)
To: Chen Gang; +Cc: David Miller, kuznet, jmorris, yoshfuji, kaber, netdev
On Tue, 2012-11-06 at 09:13 +0800, Chen Gang wrote:
> the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
> in seq_printf, it is not suitable to use %8s for ifp->idev->dev->name.
> so change it to %s, since each line has not been solid any more.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux•com>
> ---
> net/ipv6/addrconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 8f0b12a..9f728a8 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
> void *v)
> static int if6_seq_show(struct seq_file *seq, void *v)
> {
> struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
> - seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
> + seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
> &ifp->addr,
> ifp->idev->dev->ifindex,
> ifp->prefix_len,
This is a change in if6_seq_show(), not if6_seq_stop() as mentioned in
patch title.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-06 1:21 ` Eric Dumazet
@ 2012-11-06 1:26 ` Chen Gang
0 siblings, 0 replies; 9+ messages in thread
From: Chen Gang @ 2012-11-06 1:26 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, kuznet, jmorris, yoshfuji, kaber, netdev
于 2012年11月06日 09:21, Eric Dumazet 写道:
>> @@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
>> void *v)
>> static int if6_seq_show(struct seq_file *seq, void *v)
>> {
>> struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
>> - seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
>> + seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
>> &ifp->addr,
>> ifp->idev->dev->ifindex,
>> ifp->prefix_len,
>
> This is a change in if6_seq_show(), not if6_seq_stop() as mentioned in
> patch title.
>
sorry again,
I will send it again (although it will almost be spam).
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_show
2012-11-06 1:13 ` Chen Gang
2012-11-06 1:21 ` Eric Dumazet
@ 2012-11-06 1:29 ` Chen Gang
1 sibling, 0 replies; 9+ messages in thread
From: Chen Gang @ 2012-11-06 1:29 UTC (permalink / raw)
To: David Miller, kuznet, jmorris, yoshfuji, kaber; +Cc: netdev
the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for ifp->idev->dev->name.
so change it to %s, since each line has not been solid any more.
Signed-off-by: Chen Gang <gang.chen@asianux•com>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8f0b12a..9f728a8 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
void *v)
static int if6_seq_show(struct seq_file *seq, void *v)
{
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
&ifp->addr,
ifp->idev->dev->ifindex,
ifp->prefix_len,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-06 1:11 ` Chen Gang
@ 2012-11-06 1:42 ` Shan Wei
2012-11-06 1:57 ` Chen Gang
2012-11-06 3:04 ` Chen Gang
0 siblings, 2 replies; 9+ messages in thread
From: Shan Wei @ 2012-11-06 1:42 UTC (permalink / raw)
To: Chen Gang; +Cc: David Miller, kuznet, jmorris, yoshfuji, kaber, netdev
Chen Gang said, at 2012/11/6 9:11:
> 1) sorry, the comments is incorrect
> need use ifp->idev->dev->name instead of rt->dst.dev->name in 2nd line.
> I will send it again.
New patch, you should tag new version in [PATCH] to distinguish them.
i.e. [PATCH V4]
>
> 2) By the way, the three patches "* %8s to %s *" are almost the same
> If need merge them into one patch, please tell me, I shall do.
trivial patches, send them in one patch for net/ subsystem.
>
> thanks.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-06 1:42 ` Shan Wei
@ 2012-11-06 1:57 ` Chen Gang
2012-11-06 3:04 ` Chen Gang
1 sibling, 0 replies; 9+ messages in thread
From: Chen Gang @ 2012-11-06 1:57 UTC (permalink / raw)
To: Shan Wei; +Cc: David Miller, kuznet, jmorris, yoshfuji, kaber, netdev
于 2012年11月06日 09:42, Shan Wei 写道:
>
> New patch, you should tag new version in [PATCH] to distinguish them.
> i.e. [PATCH V4]
>
thanks, I shall do it next time.
>
> trivial patches, send them in one patch for net/ subsystem.
>
1) thanks, I shall do it next time.
2) if necessary
A) need send one patch for the 3 patches, this time,
B) please tell me clearly,
C) I shall do,
3) By the way:
A) for finding bugs, I truly find them one by one;
B) When I find one and send it, not know also have another one.
C) and now
i) I will continue to search the 'same' issue,
ii) if I am 'lucky' enough,
iii) maybe also can find another (but maybe not net/ subsystem)
welcome any members to giving suggestions and completions.
thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
2012-11-06 1:42 ` Shan Wei
2012-11-06 1:57 ` Chen Gang
@ 2012-11-06 3:04 ` Chen Gang
1 sibling, 0 replies; 9+ messages in thread
From: Chen Gang @ 2012-11-06 3:04 UTC (permalink / raw)
To: Shan Wei; +Cc: David Miller, kuznet, jmorris, yoshfuji, kaber, netdev
于 2012年11月06日 09:42, Shan Wei 写道:
>
> trivial patches, send them in one patch for net/ subsystem.
>
1) Lucky !
A) this time, I truly find another one for "* %8s to %s".
B) in arch/x86/kernel/process_64.c (task->comm, TASK_COMM_LEN is 16).
C) It seems that it is not suitable to send it to net subsystem.
2) Next:
A) I shall send it to relative members according to MAINTAINERS.
3) Suggestions:
welcome any members to giving additional suggestions and completions.
thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-11-06 3:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-05 11:17 [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop Chen Gang
2012-11-06 1:11 ` Chen Gang
2012-11-06 1:42 ` Shan Wei
2012-11-06 1:57 ` Chen Gang
2012-11-06 3:04 ` Chen Gang
2012-11-06 1:13 ` Chen Gang
2012-11-06 1:21 ` Eric Dumazet
2012-11-06 1:26 ` Chen Gang
2012-11-06 1:29 ` [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_show Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox