From: Ben Greear <greearb@candelatech•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev <netdev@vger•kernel.org>
Subject: Re: Can we replace the msleep(250) in dev.c netdev_wait_allrefs?
Date: Tue, 29 Jan 2013 12:24:19 -0800 [thread overview]
Message-ID: <51082FF3.4090805@candelatech.com> (raw)
In-Reply-To: <1359490897.30177.4.camel@edumazet-glaptop>
On 01/29/2013 12:21 PM, Eric Dumazet wrote:
> On Tue, 2013-01-29 at 12:00 -0800, Ben Greear wrote:
>> I think there was a proposal to change it to schedule_timeout_uninterruptible(1);
>> some time ago, but that change never made it upstream (at least not in 3.7.5)?
>>
>> Thanks,
>> Ben
>>
>
> Honestly we should fix the bug at this point, not hide it.
>
> We could use msleep(2500) to make sure people will complain ;)
Well, few will notice that either, or at least are unlikely
to know what to blame.
If we should just never reach that code, maybe a WARN_ON_ONCE() when
we do?
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-01-29 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 20:00 Can we replace the msleep(250) in dev.c netdev_wait_allrefs? Ben Greear
2013-01-29 20:21 ` Eric Dumazet
2013-01-29 20:24 ` Ben Greear [this message]
2013-01-29 20:31 ` David Miller
2013-01-29 20:45 ` Eric Dumazet
2013-01-29 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51082FF3.4090805@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox