From: Greg Ungerer <gerg@uclinux•org>
To: Frank Li <lznuaa@gmail•com>
Cc: Frank Li <Frank.Li@freescale•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
netdev@vger•kernel.org, lkml@vger•kernel.org
Subject: Re: NET: FEC: dynamtic check DMA desc buff type
Date: Mon, 04 Mar 2013 15:06:51 +1000 [thread overview]
Message-ID: <51342BEB.5020004@uclinux.org> (raw)
In-Reply-To: <CAHrpEqS_nrBzHr23vQrukQE0XmxP5EVWB44aOcMQctjzYqgnGQ@mail.gmail.com>
Hi Frank,
On 04/03/13 14:35, Frank Li wrote:
> 2013/3/4 Greg Ungerer <gerg@uclinux•org>:
>> Commit ff43da86c69d76a726ffe7d1666148960dc1d108 ("NET: FEC: dynamtic
>> check DMA desc buff type") breaks building of the fec ethernet driver
>> for non CONFIG_ARCH_MXC targets.
>>
>> For example building for ColdFire devices with FEC hardware now
>> fails like this
>>
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_nextdesc’:
>> drivers/net/ethernet/freescale/fec.c:215:18: error: invalid use of undefined
>> type ‘struct bufdesc_ex’
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_prevdesc’:
>> drivers/net/ethernet/freescale/fec.c:224:18: error: invalid use of undefined
>> type ‘struct bufdesc_ex’
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_start_xmit’:
>> drivers/net/ethernet/freescale/fec.c:286:37: error: arithmetic on pointer to
>> an incomplete type
>> drivers/net/ethernet/freescale/fec.c:287:13: error: arithmetic on pointer to
>> an incomplete type
>> drivers/net/ethernet/freescale/fec.c:324:7: error: dereferencing pointer to
>> incomplete type
>> etc....
>>
>> These where generated on 3.9-rc1.
>>
>> Can you please fix?
>
> I can fix it.
> I have not build environment to test.
> Can you help me to test it?
Oh yes, I can test any fixes.
If you had a m68k-linux compiler you can build with the
arch/m68k/configs/m5208evb_defconfig which shows the problem.
Regards
Greg
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger•kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-03-04 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 3:32 NET: FEC: dynamtic check DMA desc buff type Greg Ungerer
2013-03-04 4:35 ` Frank Li
2013-03-04 5:06 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51342BEB.5020004@uclinux.org \
--to=gerg@uclinux$(echo .)org \
--cc=Frank.Li@freescale$(echo .)com \
--cc=lkml@vger$(echo .)kernel.org \
--cc=lznuaa@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox