From: Chen Gang <gang.chen@asianux•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: isdn@linux-pingi•de, Jiri Slaby <jslaby@suse•cz>,
'Jiri Kosina' <trivial@kernel•org>,
tilman@imap•cc, David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org >> netdev" <netdev@vger•kernel.org>
Subject: Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'
Date: Tue, 02 Apr 2013 08:44:29 +0800 [thread overview]
Message-ID: <515A29ED.7010809@asianux.com> (raw)
In-Reply-To: <515993E1.5010508@cogentembedded.com>
On 2013年04月01日 22:04, Sergei Shtylyov wrote:
>
>> diff --git a/drivers/isdn/divert/isdn_divert.c
>> b/drivers/isdn/divert/isdn_divert.c
>> index db432e6..76d505e 100644
>> --- a/drivers/isdn/divert/isdn_divert.c
>> +++ b/drivers/isdn/divert/isdn_divert.c
>> @@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>> switch (dv->rule.action) {
>> case DEFLECT_IGNORE:
>> return (0);
>> - break;
>>
>> case DEFLECT_ALERT:
>> case DEFLECT_PROCEED:
>> @@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>>
>> default:
>> return (0); /* ignore call */
>> - break;
>
> You could have removed stupid () around 0, while at it.
oh, really, I should do it.
I will send patch v2 for it
thanks.
:-)
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-02 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 1:52 [PATCH] drivers/isdn/divert: beautify code, delete useless 'break' Chen Gang
2013-04-01 14:04 ` Sergei Shtylyov
2013-04-02 0:44 ` Chen Gang [this message]
2013-04-02 1:37 ` [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments Chen Gang
2013-04-02 18:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A29ED.7010809@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=isdn@linux-pingi$(echo .)de \
--cc=jslaby@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=tilman@imap$(echo .)cc \
--cc=trivial@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox