From: Chen Gang <gang.chen@asianux•com>
To: Michal Kubecek <mkubecek@suse•cz>
Cc: fengguang.wu@intel•com, isdn@linux-pingi•de,
Linus Torvalds <torvalds@linux-foundation•org>,
David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>, Joe Perches <joe@perches•com>
Subject: Re: [Suggestion] ISDN: isdnloop: C grammar issue, '}' miss match 'if' and 'switch' statement.
Date: Thu, 04 Apr 2013 17:05:23 +0800 [thread overview]
Message-ID: <515D4253.5040205@asianux.com> (raw)
In-Reply-To: <20130403140823.GB3401@unicorn.suse.cz>
On 2013年04月03日 22:08, Michal Kubecek wrote:
> On Wed, Apr 03, 2013 at 09:35:55PM +0800, Chen Gang wrote:
>> >
>> > in drivers/isdn/isdnloop/isdnloop.c
>> >
>> > issue description:
>> > it is in function 'isdnloop_command'.
>> > it seems a C grammar issue for '}' miss match 'if' and 'switch' statement
>> > please check the line 1243, 1265, 1341.
>> >
>> > building:
>> > make allyesconfig, can not let it built.
>> > in menuconfig, we (at least for me) can not let ISDN_DRV_LOOP = 'y' or 'm'.
>> > is this module a waste module which should be deleted ?
>> >
>> > the related commit:
>> > commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
>> > Author: Linus Torvalds <torvalds@ppc970•osdl.org>
>> > Date: Sat Apr 16 15:20:36 2005 -0700
> As far as I can see, this rather comes from
>
> commit 475be4d85a274d0961593db41cf85689db1d583c
> Author: Joe Perches <joe@perches•com>
> Date: Sun Feb 19 19:52:38 2012 -0800
Joe Perches only beautified the code, not change the contents.
please check thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-04 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 13:35 [Suggestion] ISDN: isdnloop: C grammar issue, '}' miss match 'if' and 'switch' statement Chen Gang
2013-04-03 14:08 ` Michal Kubecek
2013-04-03 14:31 ` Eric Dumazet
2013-04-03 15:08 ` Michal Kubecek
2013-04-03 15:30 ` Linus Torvalds
2013-04-04 8:30 ` Chen Gang
2013-04-04 18:09 ` David Miller
2013-04-05 3:00 ` Joe Perches
2013-04-05 6:13 ` Chen Gang
2013-04-05 20:37 ` Dan Williams
2013-04-06 4:56 ` Chen Gang
2013-04-05 6:09 ` Chen Gang
2013-04-04 9:05 ` Chen Gang [this message]
2013-04-04 14:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515D4253.5040205@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fengguang.wu@intel$(echo .)com \
--cc=isdn@linux-pingi$(echo .)de \
--cc=joe@perches$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox