* Re: [PATCH] Make sure GRED backlog does not get screwed up.
[not found] <CAD-Y_xtAvq5+mVe-=VDCDntY-NE2Oq+mhv56g6d8Tb2uiHw6bw@mail.gmail.com>
@ 2013-04-08 10:26 ` Jamal Hadi Salim
0 siblings, 0 replies; only message in thread
From: Jamal Hadi Salim @ 2013-04-08 10:26 UTC (permalink / raw)
To: Magnus Gille; +Cc: netdev
Hi,
please use my proper address (in the From:) for faster response.
On 13-04-02 02:32 PM, Magnus Gille wrote:
> First patch, comments, feedback, suggestions are welcome. Before this patch
> we could end up with a 4GB backlog on certain DPs without any packets. The
> patch is created against net-next.
>
> If a packet is enqueued on a GRED qdisc before the DPs are setup the packet
> will not be accounted for in the DP backlog queue.
In such a case, the packet will end up in the default queue
> When the packet later
> gets
> dequeued from the DP queue it will subtract the length from the DP backlog
> but,
> since the packet was never accounted for we now wrap the backlog around.
> Fixed
> this by making sure we never subtract more than what's present in the
> backlog.
When no DPs set: if the packet was enqueued in a default queue,
at dequeue it will be pulled from the default queue.
What am i missing?
cheers,
jamal
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-08 10:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAD-Y_xtAvq5+mVe-=VDCDntY-NE2Oq+mhv56g6d8Tb2uiHw6bw@mail.gmail.com>
2013-04-08 10:26 ` [PATCH] Make sure GRED backlog does not get screwed up Jamal Hadi Salim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox