From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Lennert Buytenhek <buytenh@wantstofly•org>,
Andrew Lunn <andrew@lunn•ch>, Jason Cooper <jason@lakedaemon•net>,
Florian Fainelli <florian@openwrt•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Dale Farnsworth <dale@farnsworth•org>,
Ben Hutchings <bhutchings@solarflare•com>,
Soeren Moch <smoch@web•de>, Willy Tarreau <w@1wt•eu>,
netdev@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] net: mv643xx_eth: remove deprecated inet_lro support
Date: Thu, 11 Apr 2013 21:52:52 +0200 [thread overview]
Message-ID: <51671494.6000803@gmail.com> (raw)
In-Reply-To: <1365709617.3887.185.camel@edumazet-glaptop>
On 04/11/2013 09:46 PM, Eric Dumazet wrote:
> On Thu, 2013-04-11 at 21:11 +0200, Sebastian Hesselbarth wrote:
>> With recent support for GRO, there is no need to keep both LRO and
>> GRO. This patch therefore removes the deprecated inet_lro support
>> from mv643xx_eth. This is work is based on an experimental patch
>> provided by Eric Dumazet and Willy Tarreau.
>>
>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail•com>
>> Based-on-patch-by: Eric Dumazet<eric.dumazet@gmail•com>
>> Based-on-patch-by: Willy Tarreau<w@1wt•eu>
>> ---
>> Note: This patch is based upon recent cleanup patches and GRO support
>> patch for mv643xx_eth.
>>
>> Cc: "David S. Miller"<davem@davemloft•net>
>> Cc: Lennert Buytenhek<buytenh@wantstofly•org>
>> Cc: Andrew Lunn<andrew@lunn•ch>
>> Cc: Jason Cooper<jason@lakedaemon•net>
>> Cc: Florian Fainelli<florian@openwrt•org>
>> Cc: Benjamin Herrenschmidt<benh@kernel•crashing.org>
>> Cc: Paul Mackerras<paulus@samba•org>
>> Cc: Dale Farnsworth<dale@farnsworth•org>
>> Cc: Ben Hutchings<bhutchings@solarflare•com>
>> Cc: Soeren Moch<smoch@web•de>
>> Cc: Eric Dumazet<eric.dumazet@gmail•com>
>> Cc: Willy Tarreau<w@1wt•eu>
>> Cc: netdev@vger•kernel.org
>> Cc: linux-arm-kernel@lists•infradead.org
>> Cc: linuxppc-dev@lists•ozlabs.org
>> Cc: linux-kernel@vger•kernel.org
>> ---
>> drivers/net/ethernet/marvell/mv643xx_eth.c | 97 +---------------------------
>> 1 file changed, 3 insertions(+), 94 deletions(-)
>
> Seems fine to me, but you also could remove "select INET_LRO"
> from drivers/net/ethernet/marvell/Kconfig
Ok, I will wait for tomorrow to see if there are more objections and
respin a v2.
Sebastian
next prev parent reply other threads:[~2013-04-11 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 19:11 [PATCH] net: mv643xx_eth: remove deprecated inet_lro support Sebastian Hesselbarth
2013-04-11 19:46 ` Eric Dumazet
2013-04-11 19:52 ` Sebastian Hesselbarth [this message]
2013-04-12 9:20 ` [PATCH v2] " Sebastian Hesselbarth
2013-04-12 12:55 ` Eric Dumazet
2013-04-12 19:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51671494.6000803@gmail.com \
--to=sebastian.hesselbarth@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhutchings@solarflare$(echo .)com \
--cc=buytenh@wantstofly$(echo .)org \
--cc=dale@farnsworth$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=florian@openwrt$(echo .)org \
--cc=jason@lakedaemon$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=smoch@web$(echo .)de \
--cc=w@1wt$(echo .)eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox