From: Mugunthan V N <mugunthanvnm@ti•com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
Cc: <netdev@vger•kernel.org>, <tglx@linutronix•de>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 2/5] net/cpsw: don't continue if we miss to allocate rx skbs
Date: Fri, 19 Apr 2013 16:10:10 +0530 [thread overview]
Message-ID: <51711F0A.50204@ti.com> (raw)
In-Reply-To: <516FE26C.5040601@linutronix.de>
On 4/18/2013 5:39 PM, Sebastian Andrzej Siewior wrote:
> On 04/18/2013 01:50 PM, Mugunthan V N wrote:
>
>>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>>> b/drivers/net/ethernet/ti/cpsw.c
>>> index e2ba702..3b22a36 100644
>>> --- a/drivers/net/ethernet/ti/cpsw.c
>>> +++ b/drivers/net/ethernet/ti/cpsw.c
>>> @@ -912,14 +912,16 @@ static int cpsw_ndo_open(struct net_device *ndev)
>>> struct sk_buff *skb;
>>> ret = -ENOMEM;
>>> - skb = netdev_alloc_skb_ip_align(priv->ndev,
>>> - priv->rx_packet_max);
>>> + skb = __netdev_alloc_skb_ip_align(priv->ndev,
>>> + priv->rx_packet_max, GFP_KERNEL);
>>> if (!skb)
>>> - break;
>>> + goto err_cleanup;
>>> ret = cpdma_chan_submit(priv->rxch, skb, skb->data,
>>> skb_tailroom(skb), 0, GFP_KERNEL);
>>> - if (WARN_ON(ret < 0))
>>> - break;
>>> + if (ret < 0) {
>>> + kfree_skb(skb);
>>> + goto err_cleanup;
>> Why you need to close the device even you have some skb allocated and
>> submitted successfully. Can allow the device to continue with lower
>> performance
> Because this should not happen. If you run out-of-memory because an
> application is going crazy than you won't have much anyway. If you
> configured too much skbs then this should be fixed as well.
>
But i am seeing most of the drivers allowing to open the device with lesser
rx skb count? But i don't know where this has been changed recently, may
be some other network experts can comment on this.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-04-19 10:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 21:52 my small cpsw queue Sebastian Andrzej Siewior
2013-04-17 21:52 ` [PATCH 1/5] net/davinci_cpdma: don't check for jiffies with interrupts Sebastian Andrzej Siewior
2013-04-18 11:49 ` Mugunthan V N
2013-04-17 21:52 ` [PATCH 2/5] net/cpsw: don't continue if we miss to allocate rx skbs Sebastian Andrzej Siewior
2013-04-18 11:50 ` Mugunthan V N
2013-04-18 12:09 ` Sebastian Andrzej Siewior
2013-04-19 10:40 ` Mugunthan V N [this message]
2013-04-22 8:05 ` Sebastian Andrzej Siewior
2013-04-17 21:52 ` [PATCH 3/5] net/cpsw: don't rely on netif_running() to check which device is active Sebastian Andrzej Siewior
2013-04-18 11:50 ` Mugunthan V N
2013-04-18 12:10 ` Sebastian Andrzej Siewior
2013-04-19 10:35 ` Mugunthan V N
2013-04-22 8:30 ` [PATCH 3/5 v2] net/cpsw: don't rely only " Sebastian Andrzej Siewior
2013-04-22 9:14 ` Mugunthan V N
2013-04-22 9:30 ` Sebastian Andrzej Siewior
2013-04-22 9:40 ` Mugunthan V N
2013-04-22 9:49 ` Sebastian Andrzej Siewior
2013-04-22 10:12 ` Mugunthan V N
2013-04-22 10:19 ` Sebastian Andrzej Siewior
2013-04-22 19:21 ` David Miller
2013-04-19 13:10 ` [PATCH 3/5] net/cpsw: don't rely " Sergei Shtylyov
2013-04-22 8:33 ` Sebastian Andrzej Siewior
2013-04-17 21:52 ` [PATCH 4/5] net/davinci_cpdma: remove unused argument in cpdma_chan_submit() Sebastian Andrzej Siewior
2013-04-18 11:51 ` Mugunthan V N
2013-04-17 21:52 ` [PATCH 5/5] net/cpsw: redo rx skb allocation in rx path Sebastian Andrzej Siewior
2013-04-18 11:50 ` Mugunthan V N
2013-04-18 12:13 ` Sebastian Andrzej Siewior
2013-04-19 10:28 ` Mugunthan V N
2013-04-18 14:59 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2013-04-23 17:31 cpsw queue, v2 Sebastian Andrzej Siewior
2013-04-23 17:31 ` [PATCH 2/5] net/cpsw: don't continue if we miss to allocate rx skbs Sebastian Andrzej Siewior
2013-04-23 17:41 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51711F0A.50204@ti.com \
--to=mugunthanvnm@ti$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox