From: Chen Gang <gang.chen@asianux•com>
To: David Miller <davem@davemloft•net>
Cc: pshelar@nicira•com, kuznet@ms2•inr.ac.ru, jmorris@namei•org,
yoshfuji@linux-ipv6•org, kaber@trash•net, netdev@vger•kernel.org
Subject: Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon
Date: Tue, 23 Apr 2013 09:46:13 +0800 [thread overview]
Message-ID: <5175E7E5.8020600@asianux.com> (raw)
In-Reply-To: <20130422.154423.1695741341535269869.davem@davemloft.net>
On 2013年04月23日 03:44, David Miller wrote:
> From: Chen Gang <gang.chen@asianux•com>
> Date: Mon, 22 Apr 2013 18:17:21 +0800
>
>> need remove erroneous semicolon.
>>
>> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>>
>> Find it by EXTRA_CFLAGS=-W
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux•com>
>
> First, what is a "type issue", you aren't changing any variable
> or declaration types in this change.
>
sorry for my poor English, maybe 'type issue' need change to 'typo
issue' ?
> Second, your formatting of your commit messages is terrible.
>
> Do not indent the description with two spaces, just keep them at the
> leftmost column. Where did you learn to indent things like that, who
> else does that? If you've never seen it before, don't invent things.
>
ok, excuse me, what I have done is only to try to make my expression
is as clearer as I can. my English is not quite well, I am afraid to let
other members can not understand or misunderstand what I write.
but since you dislike it, I will not send messages like that to you.
> It is very irritating when we see people write commit messages with
> their own style rather than mimicking what other successful
> contributors are doing.
>
sorry, I am not quite understand what your meaning. I guess your
meaning is: "you are very angry to see a member write message with his
own style. if a member is a successful contributor, he never writes
message with his own style, he only follow the public standard style".
is what I guess correct ?
thanks.
> Thanks.
>
>
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-04-23 1:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 10:17 [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon Chen Gang
2013-04-22 14:32 ` Sergei Shtylyov
2013-04-23 1:12 ` Chen Gang
2013-04-23 2:45 ` [PATCH v2] Net-next: ipv4: typo " Chen Gang
2013-04-23 5:16 ` David Miller
2013-04-23 6:35 ` Chen Gang
2013-04-23 6:45 ` [PATCH net-next v3] net: " Chen Gang
2013-04-24 18:09 ` Pravin Shelar
2013-04-25 1:20 ` Chen Gang
2013-04-25 8:08 ` David Miller
2013-04-25 8:15 ` Chen Gang
2013-04-22 19:44 ` [PATCH] Net-next: ipv4: type " David Miller
2013-04-23 1:46 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175E7E5.8020600@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox