From: Chen Gang <gang.chen@asianux•com>
To: David Miller <davem@davemloft•net>
Cc: sergei.shtylyov@cogentembedded•com, pshelar@nicira•com,
kuznet@ms2•inr.ac.ru, jmorris@namei•org, yoshfuji@linux-ipv6•org,
kaber@trash•net, netdev@vger•kernel.org
Subject: Re: [PATCH v2] Net-next: ipv4: typo issue, remove erroneous semicolon
Date: Tue, 23 Apr 2013 14:35:07 +0800 [thread overview]
Message-ID: <51762B9B.2070008@asianux.com> (raw)
In-Reply-To: <20130423.011604.1061769362231812796.davem@davemloft.net>
On 2013年04月23日 13:16, David Miller wrote:
> From: Chen Gang <gang.chen@asianux•com>
> Date: Tue, 23 Apr 2013 10:45:23 +0800
>
>> > need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W.
>> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>> > (by Pravin B Shelar <pshelar@nicira•com> Mon Mar 25 14:49:35 2013)
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux•com>
> Do not put the destination GIT tree outside of the "[]" brackets. Put
> it inside the "[]" brackets, so it doesn't show up in the final commit
> message.
>
ok, thanks.
> Also, do not capitalize it, just "net-next" is fine.
>
ok, thanks.
> Putting "(by Pravin B Shelar <pshelar@nicira•com> Mon Mar 25 14:49:35 2013)"
> is not what we asked for, we asked for the commit message header line
> which for this commit would be ("GRE: Refactor GRE tunneling code.")
>
ok, thanks.
> I want to know by what example you are doing these things? Follow
> the model of other successful patch submitters, such as Eric Dumazet,
> Ben Hutchings, Thomas Graf, Simon Horman, etc. just to name a few.
>
> Do exactly what they do, because I never have to tell those people how
> to properly format their commit messages, header lines, and the patch
> itself.
>
ok, thanks.
> In your commit message body, properly capitalize your sentences.
>
ok, thanks.
> This feedback applies to all of the patches you have submitted. I'm
> sorry I have to pick you apart so much, but if you're going to
> contribute regularly you have to get this right, I can't be constantly
> fixing up by hand every patch you submit.
>
>
ok, thanks.
need I send patch v3 ?
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-23 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 10:17 [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon Chen Gang
2013-04-22 14:32 ` Sergei Shtylyov
2013-04-23 1:12 ` Chen Gang
2013-04-23 2:45 ` [PATCH v2] Net-next: ipv4: typo " Chen Gang
2013-04-23 5:16 ` David Miller
2013-04-23 6:35 ` Chen Gang [this message]
2013-04-23 6:45 ` [PATCH net-next v3] net: " Chen Gang
2013-04-24 18:09 ` Pravin Shelar
2013-04-25 1:20 ` Chen Gang
2013-04-25 8:08 ` David Miller
2013-04-25 8:15 ` Chen Gang
2013-04-22 19:44 ` [PATCH] Net-next: ipv4: type " David Miller
2013-04-23 1:46 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51762B9B.2070008@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox