From: Nicolas Ferre <nicolas.ferre@atmel•com>
To: Steffen Trumtrar <s.trumtrar@pengutronix•de>
Cc: "Michal Simek" <monstr@monstr•eu>,
"Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@jcrosoft•com>,
"Hein Tibosch" <hein_tibosch@yahoo•es>,
netdev@vger•kernel.org, michal.simek@xilinx•com,
linux-kernel@vger•kernel.org,
"Ludovic Desroches" <ludovic.desroches@atmel•com>,
linux-arm-kernel@lists•infradead.org,
"Sören Brinkmann" <soren.brinkmann@xilinx•com>
Subject: Re: [PATCH] net/macb: fix ISR clear-on-write behavior only for some SoC
Date: Tue, 4 Jun 2013 09:51:48 +0200 [thread overview]
Message-ID: <51AD9C94.4080606@atmel.com> (raw)
In-Reply-To: <20130604064940.GA5107@pengutronix.de>
On 04/06/2013 08:49, Steffen Trumtrar :
> On Tue, Jun 04, 2013 at 08:15:45AM +0200, Michal Simek wrote:
>> On 05/14/2013 07:52 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 08:58 Tue 14 May , Hein Tibosch wrote:
>>>> On 5/14/2013 12:05 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>>> On May 14, 2013, at 12:05 AM, Nicolas Ferre <nicolas.ferre@atmel•com> wrote:
>>>>>
>>>>>> Commit 749a2b6 (net/macb: clear tx/rx completion flags in ISR)
>>>>>> introduces clear-on-write on ISR register. This behavior is not always
>>>>>> implemented when using Cadence MACB/GEM and is breaking other platforms.
>>>>>> We are using a new Device Tree compatibility string and a capability
>>>>>> property to actually activate this clear-on-write behavior on ISR.
>>>>>>
>>>>>> Reported-by: Hein Tibosch <hein_tibosch@yahoo•es>
>>>>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
>>>>> can we detect it via the IP?
>>>>
>>>> This was my first proposal, have it based on the value of MACB's
>>>> register 'MID' (offset 0x00fc, lower 16 bits).
>>>> On avr32 it reads: 0x0000010D, on Zynq it reports 0x00000119
>>>>
>>>> So for the moment, CAPS_ISR_CLEAR_ON_WRITE could be set if the revision
>>>> equals to 0x00000119?
>>> so no it will not work
>>>
>>> as the gem on sama5 is 00020119
>>>
>>> so version 0x119 too
>>>
>>> nico
>>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
>>
>> Was this added to any queue or branch?
>> I would like to enable macb for zynq and not sure if "cdns,zynq-7000-gem"
>> compatible string goes to mainline.
>>
>
> Hi!
>
> This is already in next, but you can use the default compatible as the
Even more: already in Linus' tree!
> DCR1 is used instead of DT binding.
Absolutely.
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-06-04 7:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 16:05 [PATCH] net/macb: fix ISR clear-on-write behavior only for some SoC Nicolas Ferre
2013-05-13 16:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-14 0:58 ` Hein Tibosch
2013-05-14 5:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-14 7:18 ` Hein Tibosch
2013-05-14 7:22 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-14 7:31 ` Hein Tibosch
2013-05-14 7:49 ` Michal Simek
2013-05-14 8:32 ` Hein Tibosch
2013-06-04 6:15 ` Michal Simek
2013-06-04 6:49 ` Steffen Trumtrar
2013-06-04 6:54 ` Michal Simek
2013-06-04 7:51 ` Nicolas Ferre [this message]
2013-06-04 7:57 ` Michal Simek
2013-05-14 9:16 ` Nicolas Ferre
2013-05-14 11:38 ` Michal Simek
2013-05-14 12:30 ` Nicolas Ferre
2013-05-14 7:01 ` Steffen Trumtrar
2013-05-14 13:00 ` [PATCH v2] " Nicolas Ferre
2013-05-14 13:43 ` Hein Tibosch
2013-05-14 16:24 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-14 20:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD9C94.4080606@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=hein_tibosch@yahoo$(echo .)es \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=ludovic.desroches@atmel$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=plagnioj@jcrosoft$(echo .)com \
--cc=s.trumtrar@pengutronix$(echo .)de \
--cc=soren.brinkmann@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox