From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: cphealy@gmail•com
Cc: "David S. Miller" <davem@davemloft•net>,
Fabio Estevam <fabio.estevam@freescale•com>,
Frank Li <Frank.Li@freescale•com>,
Shawn Guo <shawn.guo@linaro•org>,
Jim Baxter <jim_baxter@mentor•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH 1/1] fec: Add support to restart autonegotiate
Date: Mon, 17 Jun 2013 17:44:46 +0400 [thread overview]
Message-ID: <51BF12CE.3090502@cogentembedded.com> (raw)
In-Reply-To: <1371427478-25902-1-git-send-email-cphealy@gmail.com>
Hello.
On 17-06-2013 4:04, cphealy@gmail•com wrote:
> From: Chris <cphealy@gmail•com>
> Add ethtool operation to restart autonegotiation via the PHY.
> Also cleanup two whitespace errors that break kernel guidelines.
This "also" is asking for another patch.
> Tested on i.MX28EVK.
> Signed-off-by: Chris <cphealy@gmail•com>
You must specify your full name.
> ---
> drivers/net/ethernet/freescale/fec_main.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index a667015..c6be728 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -150,7 +150,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
> #define FEC_FLASHMAC 0xf0006000
> #elif defined(CONFIG_CANCam)
> #define FEC_FLASHMAC 0xf0020000
> -#elif defined (CONFIG_M5272C3)
> +#elif defined(CONFIG_M5272C3)
> #define FEC_FLASHMAC (0xffe04000 + 4)
> #elif defined(CONFIG_MOD5272)
> #define FEC_FLASHMAC 0xffc0406b
> @@ -1206,8 +1206,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
> if (id_entry->driver_data & FEC_QUIRK_HAS_GBIT) {
> phy_dev->supported &= PHY_GBIT_FEATURES;
> phy_dev->supported |= SUPPORTED_Pause;
> - }
> - else
> + } else
> phy_dev->supported &= PHY_BASIC_FEATURES;
According to Documentation/CodingStyle, *else* branch should have
{}, as *if* branch has it.
WBR, Sergei
next prev parent reply other threads:[~2013-06-17 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 0:04 [PATCH 1/1] fec: Add support to restart autonegotiate cphealy
2013-06-17 13:44 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-17 14:25 cphealy
2013-06-17 23:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF12CE.3090502@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=Frank.Li@freescale$(echo .)com \
--cc=cphealy@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fabio.estevam@freescale$(echo .)com \
--cc=jim_baxter@mentor$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shawn.guo@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox