From: Mugunthan V N <mugunthanvnm@ti•com>
To: David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <linux-omap@vger•kernel.org>
Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs
Date: Sat, 20 Jul 2013 13:30:07 +0530 [thread overview]
Message-ID: <51EA4387.9070301@ti.com> (raw)
In-Reply-To: <20130719.173202.1362261343675979678.davem@davemloft.net>
On 7/20/2013 6:02 AM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti•com>
> Date: Fri, 19 Jul 2013 19:37:21 +0530
>
>> Add support to show CPSW hardware statistics to user via ethtool get_regs
>> ops so user can find if there were any error reported or the system is
>> over loaded duing hagh data rate transfer.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti•com>
> This is not the correct way to provide this functionality. ->get_regs()
> is for dumping the raw hardware registers to userspace for low level
> debugging purposes, not for providing HW specific statistics.
>
> The correct thing to do is provide an appropriate implementation of
> the ->get_strings() and ->get_ethtool_stats() methods.
Will change the implementation and resubmit the patch.
Regards
Mugunthan V N
prev parent reply other threads:[~2013-07-20 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 14:07 [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs Mugunthan V N
2013-07-20 0:32 ` David Miller
2013-07-20 8:00 ` Mugunthan V N [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EA4387.9070301@ti.com \
--to=mugunthanvnm@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox