From: Daniel Borkmann <dborkman@redhat•com>
To: Fan Du <fan.du@windriver•com>
Cc: steffen.klassert@secunet•com, davem@davemloft•net,
herbert@gondor•hengli.com.au, netdev@vger•kernel.org
Subject: Re: [RFC PATCHv2 1/3] hrtimer: Add notifer for clock_was_set
Date: Wed, 07 Aug 2013 11:20:55 +0200 [thread overview]
Message-ID: <52021177.6020306@redhat.com> (raw)
In-Reply-To: <1375866296-15079-2-git-send-email-fan.du@windriver.com>
On 08/07/2013 11:04 AM, Fan Du wrote:
> When clock_was_set is called in case of system wall time change
> or host resume from suspend state, use this notifier for places
> where interested in this action.
(Only minor commenting on this one ...)
> Signed-off-by: Fan Du <fan.du@windriver•com>
> ---
> kernel/hrtimer.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
> index 383319b..b7c62a9 100644
> --- a/kernel/hrtimer.c
> +++ b/kernel/hrtimer.c
> @@ -755,6 +755,9 @@ static inline void retrigger_next_event(void *arg) { }
>
> #endif /* CONFIG_HIGH_RES_TIMERS */
>
> +ATOMIC_NOTIFIER_HEAD(clock_change_notifier_list);
> +EXPORT_SYMBOL(clock_change_notifier_list);
This should be static and hidden from other modules, e.g. have a look at
netevent_notif_chain (net/core/netevent.c).
Instead, this should be accessed via registration/un-registration handlers
for notifier blocks, and those can then be exported as EXPORT_SYMBOL_GPL
as this is core area.
> +
> /*
> * Clock realtime was set
> *
> @@ -773,6 +776,7 @@ void clock_was_set(void)
> on_each_cpu(retrigger_next_event, NULL, 1);
> #endif
> timerfd_clock_was_set();
> + atomic_notifier_call_chain(&clock_change_notifier_list, 0, 0);
Also here a small one-line handler call_clock_change_notifiers() would be
better.
> }
>
> /*
>
next prev parent reply other threads:[~2013-08-07 9:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 9:04 [RFC PATCHv2 0/3] xfrm: Refactor xfrm_state timer management Fan Du
2013-08-07 9:04 ` [RFC PATCHv2 1/3] hrtimer: Add notifer for clock_was_set Fan Du
2013-08-07 9:20 ` Daniel Borkmann [this message]
2013-08-07 9:31 ` Fan Du
2013-08-07 9:35 ` Daniel Borkmann
2013-08-14 8:52 ` [PATCHv3 linux-next] hrtimer: Add notifier when clock_was_set was called Fan Du
2013-08-14 19:04 ` Sergei Shtylyov
2013-08-18 9:05 ` Thomas Gleixner
2013-08-20 1:56 ` Fan Du
2013-09-12 13:21 ` Thomas Gleixner
2013-09-12 13:44 ` Herbert Xu
2013-09-12 14:43 ` Thomas Gleixner
2013-09-12 17:32 ` David Miller
2013-09-12 19:37 ` Thomas Gleixner
2013-09-13 2:46 ` Fan Du
2013-09-13 14:32 ` Thomas Gleixner
2013-09-16 0:26 ` Fan Du
2013-09-16 9:01 ` Thomas Gleixner
2013-09-17 7:47 ` Fan Du
2013-09-12 20:35 ` John Stultz
2013-09-12 20:41 ` Thomas Gleixner
2013-08-07 9:04 ` [RFC PATCHv2 2/3] xfrm: Update xfrm_state lifetime expire after clock_was_set Fan Du
2013-08-14 5:26 ` [PATCHv3 net-next ] " Fan Du
2013-08-14 11:04 ` Steffen Klassert
2013-08-07 9:04 ` [RFC PATCHv2 3/3] xfrm: Revert "Fix unexpected SA hard expiration after changing date" Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52021177.6020306@redhat.com \
--to=dborkman@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fan.du@windriver$(echo .)com \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox