From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Fan Du <fan.du@windriver•com>
Cc: tglx@linutronix•de,
Steffen Klassert <steffen.klassert@secunet•com>,
David Miller <davem@davemloft•net>,
Herbert Xu <herbert@gondor•hengli.com.au>,
Daniel Borkmann <dborkman@redhat•com>,
LKML <linux-kernel@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCHv3 linux-next] hrtimer: Add notifier when clock_was_set was called
Date: Wed, 14 Aug 2013 23:04:29 +0400 [thread overview]
Message-ID: <520BD4BD.3010300@cogentembedded.com> (raw)
In-Reply-To: <520B4552.2000607@windriver.com>
Hello.
On 08/14/2013 12:52 PM, Fan Du wrote:
> From e3929d4fdfad5b40fd8cad0e217597670d1aef54 Mon Sep 17 00:00:00 2001
> From: Fan Du <fan.du@windriver•com>
> Date: Wed, 14 Aug 2013 16:39:23 +0800
> Subject: [PATCHv3 linux-next] hrtimer: Add notifier when clock_was_set was called
This header is not needed.
> When clock_was_set is called in case of system wall time change
> or host resume from suspend state, use this notifier for places
> where interested in this action, e.g Ipsec SA lifetime management.
> Signed-off-by: Fan Du <fan.du@windriver•com>
> v3:
> -Beautify notifier with register/unregister API exported for other subsystem.
[...]
> diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
> index d19a5c2..f0404e4 100644
> --- a/include/linux/hrtimer.h
> +++ b/include/linux/hrtimer.h
> @@ -461,4 +461,7 @@ extern u64 ktime_divns(const ktime_t kt, s64 div);
> /* Show pending timers: */
> extern void sysrq_timer_list_show(void);
>
> +extern int register_clock_change_notifier(struct notifier_block *nb);
> +extern int unregister_clock_change_notifier(struct notifier_block *nb);
> +
> #endif
> diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
> index 383319b..c6e6405 100644
> --- a/kernel/hrtimer.c
> +++ b/kernel/hrtimer.c
> @@ -755,6 +755,24 @@ static inline void retrigger_next_event(void *arg) { }
>
> #endif /* CONFIG_HIGH_RES_TIMERS */
>
> +static ATOMIC_NOTIFIER_HEAD(clock_change_notifier_list);
> +static int call_clock_change_notifiers(void)
> +{
> + return atomic_notifier_call_chain(&clock_change_notifier_list, 0, 0);
> +}
> +
> +int register_clock_change_notifier(struct notifier_block *nb)
> +{
> + return atomic_notifier_chain_register(&clock_change_notifier_list, nb);
> +}
> +EXPORT_SYMBOL_GPL(register_clock_change_notifier);
> +
> +int unregister_clock_change_notifier(struct notifier_block *nb)
> +{
> + return atomic_notifier_chain_unregister(&clock_change_notifier_list, nb);
> +}
> +EXPORT_SYMBOL_GPL(unregister_clock_change_notifier);
> +
> /*
> * Clock realtime was set
> *
> @@ -773,6 +791,7 @@ void clock_was_set(void)
> on_each_cpu(retrigger_next_event, NULL, 1);
> #endif
> timerfd_clock_was_set();
> + call_clock_change_notifiers();
> }
Your patch seems whitepsace damaged, i.e. a space is added before each
line starting with space.
WBR, Sergei
next prev parent reply other threads:[~2013-08-14 19:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 9:04 [RFC PATCHv2 0/3] xfrm: Refactor xfrm_state timer management Fan Du
2013-08-07 9:04 ` [RFC PATCHv2 1/3] hrtimer: Add notifer for clock_was_set Fan Du
2013-08-07 9:20 ` Daniel Borkmann
2013-08-07 9:31 ` Fan Du
2013-08-07 9:35 ` Daniel Borkmann
2013-08-14 8:52 ` [PATCHv3 linux-next] hrtimer: Add notifier when clock_was_set was called Fan Du
2013-08-14 19:04 ` Sergei Shtylyov [this message]
2013-08-18 9:05 ` Thomas Gleixner
2013-08-20 1:56 ` Fan Du
2013-09-12 13:21 ` Thomas Gleixner
2013-09-12 13:44 ` Herbert Xu
2013-09-12 14:43 ` Thomas Gleixner
2013-09-12 17:32 ` David Miller
2013-09-12 19:37 ` Thomas Gleixner
2013-09-13 2:46 ` Fan Du
2013-09-13 14:32 ` Thomas Gleixner
2013-09-16 0:26 ` Fan Du
2013-09-16 9:01 ` Thomas Gleixner
2013-09-17 7:47 ` Fan Du
2013-09-12 20:35 ` John Stultz
2013-09-12 20:41 ` Thomas Gleixner
2013-08-07 9:04 ` [RFC PATCHv2 2/3] xfrm: Update xfrm_state lifetime expire after clock_was_set Fan Du
2013-08-14 5:26 ` [PATCHv3 net-next ] " Fan Du
2013-08-14 11:04 ` Steffen Klassert
2013-08-07 9:04 ` [RFC PATCHv2 3/3] xfrm: Revert "Fix unexpected SA hard expiration after changing date" Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BD4BD.3010300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=fan.du@windriver$(echo .)com \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox