From: Ben Greear <greearb@candelatech•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] veth: remove hardware checksum feature
Date: Thu, 08 Aug 2013 12:43:34 -0700 [thread overview]
Message-ID: <5203F4E6.1010701@candelatech.com> (raw)
In-Reply-To: <1375930325.4004.88.camel@edumazet-glaptop>
On 08/07/2013 07:52 PM, Eric Dumazet wrote:
> On Wed, 2013-08-07 at 18:54 -0700, Ben Greear wrote:
>
>> Maybe we should just do the csum calc in the kernel if packet is
>> about to be sent up to user-space via af_packet? I think that
>> would keep the expected behaviour, and hopefully not loose any of the performance
>> benefits for cases where the packet never leaves the kernel?
>
> I think you are rephrasing what I suggested ;)
>
> I'll send a patch asap, unless someone beats me.
I'll be happy to test.
And a slightly related question if you have the time:
My kernel-mode bridge was breaking as well, but this appears to
be a bug in my code. I had this code (since 2009, at least):
// Evidently this fixes issues with sending between NICs
// that support and do not support hw-csum.
skb->ip_summed = CHECKSUM_NONE;
It seems that at some point, this fixed some problem I saw, but it was long
ago. If I remove this, then the 3.9 kernel bridges just fine between
the VETH and a physical interface.
I do not see any modification of the ip_summed in the bridge code.
So, the question is: Is there any time that I *should* be mucking with
skb->ip_summed when bridging pkts from one device to another on modern
kernels? I'm using the ptype_all hook to grab packets, and ndo_start_xmit
to send them, in case that matters.
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-08-08 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 17:20 [PATCH] veth: remove hardware checksum feature Vitaly E. Lavrov
2013-07-25 17:59 ` Eric Dumazet
2013-08-08 0:07 ` Ben Greear
2013-08-08 0:12 ` Eric Dumazet
2013-08-08 0:23 ` Ben Greear
2013-08-08 1:08 ` Eric Dumazet
2013-08-08 1:54 ` Ben Greear
2013-08-08 2:52 ` Eric Dumazet
2013-08-08 19:43 ` Ben Greear [this message]
2013-08-08 20:16 ` Eric Dumazet
2013-08-08 22:13 ` Ben Greear
2013-08-08 22:20 ` Ben Greear
2013-08-08 22:22 ` Eric Dumazet
2013-08-08 22:35 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203F4E6.1010701@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox