From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Libo Chen <clbchenlibo.chen@huawei•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Li Zefan <lizefan@huawei•com>
Subject: Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
Date: Wed, 14 Aug 2013 22:54:45 +0400 [thread overview]
Message-ID: <520BD275.5060004@cogentembedded.com> (raw)
In-Reply-To: <520AFBEE.7030903@huawei.com>
Hello.
On 08/14/2013 07:39 AM, Libo Chen wrote:
> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
You misunderstood. That's a material for 2 separate patch sets (or maybe
single patches, since multiple files can be collapsed in a single patch).
> Signed-off-by: Libo Chen <libo.chen@huawei•com>
WBR, Sergei
next prev parent reply other threads:[~2013-08-14 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 13:24 [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 18:10 ` Sergei Shtylyov
2013-08-14 3:39 ` [PATCH RESEND " Libo Chen
2013-08-14 18:54 ` Sergei Shtylyov [this message]
2013-08-15 9:27 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BD275.5060004@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=clbchenlibo.chen@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox