From: Libo Chen <clbchenlibo.chen@huawei•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>,
Li Zefan <lizefan@huawei•com>
Subject: Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
Date: Thu, 15 Aug 2013 17:27:40 +0800 [thread overview]
Message-ID: <520C9F0C.6040303@huawei.com> (raw)
In-Reply-To: <520BD275.5060004@cogentembedded.com>
On 2013/8/15 2:54, Sergei Shtylyov wrote:
> Hello.
>
> On 08/14/2013 07:39 AM, Libo Chen wrote:
>
>> We can use the wrapper functions platform_{get,set}_drvdata() instead of
>> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
>
>> Also, unnecessary dev_set_drvdata() is removed, because the driver core
>> clears the driver data to NULL after device_release or on probe failure.
>
> You misunderstood. That's a material for 2 separate patch sets (or maybe single patches, since multiple files can be collapsed in a single patch).
>
okay, thanks.
Libo
>> Signed-off-by: Libo Chen <libo.chen@huawei•com>
>
> WBR, Sergei
>
>
>
prev parent reply other threads:[~2013-08-15 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 13:24 [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 18:10 ` Sergei Shtylyov
2013-08-14 3:39 ` [PATCH RESEND " Libo Chen
2013-08-14 18:54 ` Sergei Shtylyov
2013-08-15 9:27 ` Libo Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520C9F0C.6040303@huawei.com \
--to=clbchenlibo.chen@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox