public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>,
	Yoshinori Sato <ysato@users•sourceforge.jp>,
	Kees Cook <keescook@chromium•org>
Cc: David Miller <davem@davemloft•net>, netdev <netdev@vger•kernel.org>
Subject: [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
Date: Fri, 30 Aug 2013 11:29:37 +0800	[thread overview]
Message-ID: <522011A1.2080305@asianux.com> (raw)

Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
will no related irq and base address).

The release error:

    CC [M]  drivers/net/hamradio/bpqether.o
  drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
  drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
  drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
  drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
  drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
  drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
  drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
  drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
  drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
 

Signed-off-by: Chen Gang <gang.chen@asianux•com>
---
 drivers/net/ethernet/8390/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
index a5f91e1..becef25 100644
--- a/drivers/net/ethernet/8390/Kconfig
+++ b/drivers/net/ethernet/8390/Kconfig
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
 
 config NE_H8300
 	tristate "NE2000 compatible support for H8/300"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	---help---
 	  Say Y here if you want to use the NE2000 compatible
 	  controller on the Renesas H8/300 processor.
-- 
1.7.7.6

             reply	other threads:[~2013-08-30  3:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  3:29 Chen Gang [this message]
2013-08-30 14:36 ` [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300 Paul Gortmaker
2013-09-02  1:48   ` Chen Gang
2013-09-02  2:39     ` Chen Gang
2013-09-02  2:20   ` [PATCH v2] " Chen Gang
2013-09-04  2:37     ` David Miller
2013-09-04  2:52       ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522011A1.2080305@asianux.com \
    --to=gang.chen@asianux$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=keescook@chromium$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=paul.gortmaker@windriver$(echo .)com \
    --cc=ysato@users$(echo .)sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox