From: Chen Gang <gang.chen@asianux•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: Yoshinori Sato <ysato@users•sourceforge.jp>,
Kees Cook <keescook@chromium•org>,
David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300
Date: Mon, 02 Sep 2013 10:39:59 +0800 [thread overview]
Message-ID: <5223FA7F.4030202@asianux.com> (raw)
In-Reply-To: <5223EE80.8000305@asianux.com>
On 09/02/2013 09:48 AM, Chen Gang wrote:
> On 08/30/2013 10:36 PM, Paul Gortmaker wrote:
>> [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote:
>>
>>> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it
>>> will no related irq and base address).
>>
>> Do you have an H83000 and really know that is true? I'm guessing no.
Oh, sorry, forgot reply this item.
And I have no related hardware (I am just cross compiling).
Hmm... according to the implementation, we can assume original author
though: "currently only H8300H_AKI3068NET and H8300H_H8MAX can/need
support NE_H8300" (may better use "need" instead of "can").
Thanks.
>>
>> Looking at the driver, it is kind of broken that it only assigns I/O and
>> irq for two platforms, but the H8300 arch Kconfig.cpu only allows building
>> a single platform in a given kernel anyway, so a dependency fix is
>> probably acceptable here.
>>
>
> OK, thanks.
>
>> Given that, what you really want to indicate is something like:
>>
>> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default
>> I/O base and IRQ values for the NE_H8300 driver. Hence builds
>> for other H8300H platforms will fail as per below. Since H8300H
>> does not support multi platform builds, we simply limit building
>> the driver to those two platforms specifically.
>>
>
> Hmm... that sounds good to me.
>
>>>
>>> The release error:
>>>
>>> CC [M] drivers/net/hamradio/bpqether.o
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> This file has nothing to do with the problem in question. [If you are
>> going to do a "make -j30" in testing, then at least restart with -j1 to
>> properly capture the error message.]
>>
>
> Oh, it is a waste, which I should remove, thanks.
>
>
>> Please update the commit log appropriately and resubmit.
>>
>
> OK, I will send patch v2.
>
>> Paul.
>> --
>>
>>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
>>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant
>>> drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
>>> drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function)
>>> drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux•com>
>>> ---
>>> drivers/net/ethernet/8390/Kconfig | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
>>> index a5f91e1..becef25 100644
>>> --- a/drivers/net/ethernet/8390/Kconfig
>>> +++ b/drivers/net/ethernet/8390/Kconfig
>>> @@ -148,7 +148,7 @@ config PCMCIA_PCNET
>>>
>>> config NE_H8300
>>> tristate "NE2000 compatible support for H8/300"
>>> - depends on H8300
>>> + depends on H8300H_AKI3068NET || H8300H_H8MAX
>>> ---help---
>>> Say Y here if you want to use the NE2000 compatible
>>> controller on the Renesas H8/300 processor.
>>> --
>>> 1.7.7.6
>>
>>
>
> Thanks.
>
--
Chen Gang
next prev parent reply other threads:[~2013-09-02 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 3:29 [PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300 Chen Gang
2013-08-30 14:36 ` Paul Gortmaker
2013-09-02 1:48 ` Chen Gang
2013-09-02 2:39 ` Chen Gang [this message]
2013-09-02 2:20 ` [PATCH v2] " Chen Gang
2013-09-04 2:37 ` David Miller
2013-09-04 2:52 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5223FA7F.4030202@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=keescook@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox