From: Duan Jiong <djduanjiong@gmail•com>
To: David Miller <davem@davemloft•net>, duanj.fnst@cn•fujitsu.com
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error code in icmpv6_err_convert
Date: Thu, 19 Sep 2013 13:24:04 +0800 [thread overview]
Message-ID: <523A8A74.30005@gmail.com> (raw)
In-Reply-To: <20130918.123613.61436246160249555.davem@davemloft.net>
于 2013/9/19 0:36, David Miller 写道:
> From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
> Date: Wed, 18 Sep 2013 20:04:48 +0800
>
>> From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
>>
>> when dealing with redirect message in udpv6_err() and
>> rawv6_err() the err shoud be assigned to 0, not EPROTO.
>>
>> Signed-off-by: Duan Jiong <duanj.fnst@cn•fujitsu.com>
> No, you should fix this the same way you handled DCCP, but skipping
> the whole socket error setting path for NDISC_REDIRECT.
Your meaning is that we should return directly after calling
ip6_sk_redirect(), is that it?
Thanks,
Duan
> Clearing the socket error to zero is not correct, it means you will
> lose any existing error setting.
next prev parent reply other threads:[~2013-09-19 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 12:04 [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error code in icmpv6_err_convert Duan Jiong
2013-09-18 16:36 ` David Miller
2013-09-18 18:00 ` Hannes Frederic Sowa
2013-09-19 5:24 ` Duan Jiong [this message]
2013-09-19 18:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523A8A74.30005@gmail.com \
--to=djduanjiong@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=duanj.fnst@cn$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox