From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Mark Repka <repkam09@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [net-next] Fix hardcoded ni65 interrupt name to use system device value
Date: Sat, 21 Sep 2013 23:48:33 +0400 [thread overview]
Message-ID: <523DF811.3010209@cogentembedded.com> (raw)
In-Reply-To: <1379791939-23887-1-git-send-email-repkam09@gmail.com>
Hello.
On 09/21/2013 11:32 PM, Mark Repka wrote:
> The ni65 interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
Please wrap your changelog lines at 80 columns (preferably even less).
> Signed-off-by: Mark Repka <repkam09@gmail•com>
> ---
> drivers/net/ethernet/amd/ni65.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c
> index 1cf33ad..00cb6db 100644
> --- a/drivers/net/ethernet/amd/ni65.c
> +++ b/drivers/net/ethernet/amd/ni65.c
> @@ -295,7 +295,7 @@ static int ni65_open(struct net_device *dev)
> {
> struct priv *p = dev->ml_priv;
> int irqval = request_irq(dev->irq, ni65_interrupt,0,
> - cards[p->cardno].cardname,dev);
> + dev->name,dev);
Don't indent with all spaces, use tabs at the start of line. And start the
line under 'dev->irq' please.
WBR, Sergei
prev parent reply other threads:[~2013-09-21 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 19:32 [net-next] Fix hardcoded ni65 interrupt name to use system device value Mark Repka
2013-09-21 19:48 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523DF811.3010209@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=repkam09@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox