From: Mark Lord <mlord@pobox•com>
To: David Laight <David.Laight@ACULAB•COM>,
Eric Dumazet <eric.dumazet@gmail•com>,
Ming Lei <ming.lei@canonical•com>,
davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: net/usb/ax88179_178a driver broken in linux-3.12
Date: Mon, 18 Nov 2013 17:52:38 -0500 [thread overview]
Message-ID: <528A9A36.50903@pobox.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B742F@saturn3.aculab.com>
On 13-11-18 08:32 AM, David Laight wrote:
>> From: David Laight
>>> On 13-11-17 01:56 PM, Mark Lord wrote:
>>>> On 13-11-17 01:35 PM, Mark Lord wrote:
>>>>> The USB3 network adapter locks up consistently for me here in 3.12,
>>>>> but was working without issues in 3.11.x
>>
>> The xhci driver is well broken in 3.12.
>
> To correct myself...
>
> The xhci driver has never correctly support scatter-gather requests.
> In 3.12 code was added to usbnet to generate SG transmits, and to the
> ax88179_178a driver to use them.
> TCP segmentation offload was then enabled - with does generate
> SG transfers.
>
> SG transfers for 'disks' almost certainly work because the
> fragment boundaries are 'adequately aligned'.
>
> David
>
Well, that's all very nice and whatnot,
except the ax88179_178a driver still does not work in linux-3.12,
whereas it works fine in all earlier kernels.
That's a regression.
And a simple revert (earlier in this thread) fixes it.
So.. let's revert it for now, until a proper xhci compatible patch is produced.
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox•com
next prev parent reply other threads:[~2013-11-18 22:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52890C7E.6000607@pobox.com>
2013-11-17 18:56 ` net/usb/ax88179_178a driver broken in linux-3.12 Mark Lord
2013-11-17 19:04 ` Mark Lord
2013-11-18 10:12 ` David Laight
2013-11-18 13:32 ` David Laight
2013-11-18 22:52 ` Mark Lord [this message]
2013-11-19 10:04 ` David Laight
2013-11-19 13:44 ` Mark Lord
2013-11-19 13:56 ` David Laight
2013-11-19 14:02 ` Mark Lord
2013-11-19 14:15 ` Eric Dumazet
2013-11-19 14:24 ` Mark Lord
2013-11-19 14:43 ` David Laight
2013-11-19 16:10 ` Eric Dumazet
2013-11-19 16:26 ` David Laight
2013-11-19 21:13 ` David Miller
2013-11-20 9:54 ` David Laight
2013-11-20 16:54 ` Sarah Sharp
2013-11-30 2:58 ` Mark Lord
[not found] ` <5299546B.2020800-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2013-12-02 9:30 ` David Laight
2013-12-02 15:05 ` Mark Lord
[not found] ` <529CA1D2.2070806-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2013-12-02 19:08 ` Sarah Sharp
2013-12-02 19:11 ` Mark Lord
2013-12-02 19:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A9A36.50903@pobox.com \
--to=mlord@pobox$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=ming.lei@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox