From: Mark Lord <mlord@pobox•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Laight <David.Laight@ACULAB•COM>,
Ming Lei <ming.lei@canonical•com>,
davem@davemloft•net, netdev@vger•kernel.org,
Linux Kernel <linux-kernel@vger•kernel.org>,
stable@vger•kernel.org
Subject: Re: net/usb/ax88179_178a driver broken in linux-3.12
Date: Tue, 19 Nov 2013 09:24:27 -0500 [thread overview]
Message-ID: <528B749B.7050304@pobox.com> (raw)
In-Reply-To: <1384870550.8604.101.camel@edumazet-glaptop2.roam.corp.google.com>
On 13-11-19 09:15 AM, Eric Dumazet wrote:
> On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote:
>> On 13-11-19 05:04 AM, David Laight wrote:
>>>> From: Mark Lord
>> ..
>>>> except the ax88179_178a driver still does not work in linux-3.12,
>>>> whereas it works fine in all earlier kernels.
>>>>
>>>> That's a regression.
>>>> And a simple revert (earlier in this thread) fixes it.
>>>> So.. let's revert it for now, until a proper xhci compatible patch is produced.
>> ...
>>> There is a patch to xhci-ring.c that should fix the SG problem.
>>> http://www.spinics.net/lists/linux-usb/msg97176.html
>>>
>>> I think it should apply to the 3.12 sources.
>>
>> I am running with that patch here now (thanks),
>> and it too appears to prevent the lockups.
>>
>> But is this patch upstream already?
>> If yes, then it needs to get pushed out to -stable for 3.12 at least.
>>
>> If not upstream, then the revert is probably safest for -stable,
>> rather than new code that has never been upstream before.
>>
>
>> Both patches are attached to this email.
>> One or the other is required for the USB 3.0 network adapters to function in 3.12.
>
> I do not see any error in commit f27070158d6754765f2
> ("ax88179_178a: avoid copy of tx tcp packets")
> Quite the contrary in fact...
>
> I suspect a TSO bug, and would rather disable TSO for this nic.
David's explanation for the XHCI issue seems to explain it nicely,
and the patch he linked to does indeed address/fix the issue,
without disabling TSO.
So on the evidence, probably NOT a TSO bug.
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox•com
next prev parent reply other threads:[~2013-11-19 14:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52890C7E.6000607@pobox.com>
2013-11-17 18:56 ` net/usb/ax88179_178a driver broken in linux-3.12 Mark Lord
2013-11-17 19:04 ` Mark Lord
2013-11-18 10:12 ` David Laight
2013-11-18 13:32 ` David Laight
2013-11-18 22:52 ` Mark Lord
2013-11-19 10:04 ` David Laight
2013-11-19 13:44 ` Mark Lord
2013-11-19 13:56 ` David Laight
2013-11-19 14:02 ` Mark Lord
2013-11-19 14:15 ` Eric Dumazet
2013-11-19 14:24 ` Mark Lord [this message]
2013-11-19 14:43 ` David Laight
2013-11-19 16:10 ` Eric Dumazet
2013-11-19 16:26 ` David Laight
2013-11-19 21:13 ` David Miller
2013-11-20 9:54 ` David Laight
2013-11-20 16:54 ` Sarah Sharp
2013-11-30 2:58 ` Mark Lord
[not found] ` <5299546B.2020800-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2013-12-02 9:30 ` David Laight
2013-12-02 15:05 ` Mark Lord
[not found] ` <529CA1D2.2070806-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2013-12-02 19:08 ` Sarah Sharp
2013-12-02 19:11 ` Mark Lord
2013-12-02 19:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B749B.7050304@pobox.com \
--to=mlord@pobox$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=ming.lei@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox