From: Wang Weidong <wangweidong1@huawei•com>
To: Neil Horman <nhorman@tuxdriver•com>
Cc: Vlad Yasevich <vyasevich@gmail•com>,
David Miller <davem@davemloft•net>, <linux-sctp@vger•kernel.org>,
<netdev@vger•kernel.org>, <dingtianhong@huawei•com>
Subject: Re: [PATCH] sctp: make the max_burst min value to 1
Date: Mon, 2 Dec 2013 20:03:19 +0800 [thread overview]
Message-ID: <529C7707.5020908@huawei.com> (raw)
In-Reply-To: <20131202115640.GA10857@hmsreliant.think-freely.org>
On 2013/12/2 19:56, Neil Horman wrote:
> On Mon, Dec 02, 2013 at 02:51:45PM +0800, Wang Weidong wrote:
>> From: Wang Weidong <wangweidong1@huawei•com>
>>
>> when I setted the max_burst to 0, do the lksctp-tools I got hang.
>> I found sctp_transport_burst_limited would make the cwnd to 0.
>> so I make the max_burst min value to 1.
>> Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
>> ---
>> net/sctp/sysctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
>> index 7637e8e..46832d3 100644
>> --- a/net/sctp/sysctl.c
>> +++ b/net/sctp/sysctl.c
>> @@ -135,7 +135,7 @@ static struct ctl_table sctp_net_table[] = {
>> .maxlen = sizeof(int),
>> .mode = 0644,
>> .proc_handler = proc_dointvec_minmax,
>> - .extra1 = &zero,
>> + .extra1 = &one,
>> .extra2 = &int_max
>> },
>> {
>> --
>> 1.7.12
>>
>>
>
>
> This seems like a band-aid to me. There are a few things wrong:
>
> 1) You can also set the the max_burst via setsockopt, and so this would need to
> be checked in that path as well.
>
> 2) I don't see how having a cwnd of zero would cause a hang. It looks like a
> cwnd of zero would perpetually place the association in a slow start state,
> which is silly but not illegal.
>
Hm, Good suggestions. Ok, I will try it again and find the root cause.
Thanks!
> Please investigate the acutally root cause of the problem before just avoiding
> it like this.
>
> Thanks!
> Neil
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2013-12-02 12:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 6:51 [PATCH] sctp: make the max_burst min value to 1 Wang Weidong
2013-12-02 11:56 ` Neil Horman
2013-12-02 12:03 ` Wang Weidong [this message]
2013-12-02 14:51 ` Vlad Yasevich
2013-12-03 1:35 ` Wang Weidong
2013-12-02 13:08 ` Michael Tuexen
2013-12-03 6:30 ` [PATCH] sctp: disable max_burst when the max_burst is 0 Wang Weidong
2013-12-04 8:57 ` Daniel Borkmann
2013-12-04 9:16 ` Wang Weidong
2013-12-04 9:32 ` [PATCH v2] " Wang Weidong
2013-12-04 11:45 ` Neil Horman
2013-12-04 14:28 ` Vlad Yasevich
2013-12-06 1:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C7707.5020908@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox