From: Wang Weidong <wangweidong1@huawei•com>
To: David Miller <davem@davemloft•net>,
Neil Horman <nhorman@tuxdriver•com>,
Vlad Yasevich <vyasevich@gmail•com>
Cc: Michael Tuexen <Michael.Tuexen@lurchi•franken.de>,
<linux-sctp@vger•kernel.org>, <netdev@vger•kernel.org>,
<dingtianhong@huawei•com>
Subject: [PATCH] sctp: disable max_burst when the max_burst is 0
Date: Tue, 3 Dec 2013 14:30:26 +0800 [thread overview]
Message-ID: <529D7A82.3070207@huawei.com> (raw)
In-Reply-To: <DABC28BB-074A-42CE-ACEC-BE9893B4ED06@lurchi.franken.de>
As Michael pointed out that when max_burst is 0, it just disable
max_burst. It declared in rfc6458#section-8.1.24. so add the check
in sctp_transport_burst_limited, when it 0, just do nothing.
Suggested-by: Vlad Yasevich <vyasevich@gmail•com>
Suggested-by: Michael Tuexen <Michael.Tuexen@lurchi•franken.de>
Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
---
net/sctp/transport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/sctp/transport.c b/net/sctp/transport.c
index e332efb..e580e34 100644
--- a/net/sctp/transport.c
+++ b/net/sctp/transport.c
@@ -573,7 +573,8 @@ void sctp_transport_burst_limited(struct sctp_transport *t)
u32 old_cwnd = t->cwnd;
u32 max_burst_bytes;
- if (t->burst_limited)
+ /* if the max_burst is 0, do notihing */
+ if (t->burst_limited || !asoc->max_burst)
return;
max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu);
--
1.7.12
next prev parent reply other threads:[~2013-12-03 6:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 6:51 [PATCH] sctp: make the max_burst min value to 1 Wang Weidong
2013-12-02 11:56 ` Neil Horman
2013-12-02 12:03 ` Wang Weidong
2013-12-02 14:51 ` Vlad Yasevich
2013-12-03 1:35 ` Wang Weidong
2013-12-02 13:08 ` Michael Tuexen
2013-12-03 6:30 ` Wang Weidong [this message]
2013-12-04 8:57 ` [PATCH] sctp: disable max_burst when the max_burst is 0 Daniel Borkmann
2013-12-04 9:16 ` Wang Weidong
2013-12-04 9:32 ` [PATCH v2] " Wang Weidong
2013-12-04 11:45 ` Neil Horman
2013-12-04 14:28 ` Vlad Yasevich
2013-12-06 1:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D7A82.3070207@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=Michael.Tuexen@lurchi$(echo .)franken.de \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox