From: Gao feng <gaofeng@cn•fujitsu.com>
To: RongQing Li <roy.qing.li@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy
Date: Tue, 17 Dec 2013 13:57:55 +0800 [thread overview]
Message-ID: <52AFE7E3.3070806@cn.fujitsu.com> (raw)
In-Reply-To: <CAJFZqHwF0ubvxJOs2BWbSMMB1szKNO=XTiXje3E2ByF6sUQrXA@mail.gmail.com>
On 12/17/2013 11:32 AM, RongQing Li wrote:
> If the ort->rt6i_flags is RTF_EXPIRES|RTF_ADDRCONF, then rt6_set_from will not
> be called, and new created rt will have RTF_EXPIRES, but dst.expires is 0, and
> dst.from is NULL
Ok, but I think you need to add more detail/test purpose of the test case v6LC.4.1.4
{ Reduce PMTU On-link }. just the number of test case is not good for people to know
what's the real problem.
>
> -Roy
>
> 2013/12/17 Gao feng <gaofeng@cn•fujitsu.com>:
>> On 12/16/2013 04:31 PM, roy.qing.li@gmail•com wrote:
>>> From: Li RongQing <roy.qing.li@gmail•com>
>>>
>>> The commit ecd9883724b [ipv6: fix race condition regarding dst->expires and
>>> dst->from.] removed rt6_clean_expires in ip6_rt_copy, which causes the TAHI
>>> test case v6LC.4.1.4 { Reduce PMTU On-link } failed, since the newly generated
>>> rt maybe always expired {with RTF_EXPIRES flag, dst.expires is 0, and dst.from
>>> is NULL}.
>>>
>>> Fix it by clearing RTF_EXPIRES as before 1716a96101[ipv6: fix problem with
>>> expired dst cache]
>>>
>>> Signed-off-by: Li RongQing <roy.qing.li@gmail•com>
>>> ---
>>> net/ipv6/route.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>>> index a1a5752..e3d7f21 100644
>>> --- a/net/ipv6/route.c
>>> +++ b/net/ipv6/route.c
>>> @@ -1908,7 +1908,7 @@ static struct rt6_info *ip6_rt_copy(struct rt6_info *ort,
>>> rt->rt6i_gateway = ort->rt6i_gateway;
>>> else
>>> rt->rt6i_gateway = *dest;
>>> - rt->rt6i_flags = ort->rt6i_flags;
>>> + rt->rt6i_flags = ort->rt6i_flags & ~RTF_EXPIRES;
>>> if ((ort->rt6i_flags & (RTF_DEFAULT | RTF_ADDRCONF)) ==
>>> (RTF_DEFAULT | RTF_ADDRCONF))
>>> rt6_set_from(rt, ort);
>>>
>>
>> I don't understand, rt6_set_from already clears the RTF_EXPIRES from rt->rt6i_flags.
>>
>
next prev parent reply other threads:[~2013-12-17 5:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:31 [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy roy.qing.li
2013-12-16 13:47 ` Eric Dumazet
2013-12-17 3:25 ` Gao feng
2013-12-17 3:32 ` RongQing Li
2013-12-17 5:57 ` Gao feng [this message]
2013-12-17 6:42 ` RongQing Li
2013-12-17 7:02 ` Hannes Frederic Sowa
2013-12-17 7:46 ` Gao feng
2013-12-17 8:30 ` Hannes Frederic Sowa
2013-12-17 9:23 ` Gao feng
2013-12-17 13:48 ` Hannes Frederic Sowa
2013-12-18 0:48 ` Gao feng
2013-12-18 1:58 ` RongQing Li
2013-12-18 2:09 ` Gao feng
2013-12-18 2:21 ` RongQing Li
2013-12-18 6:20 ` Hannes Frederic Sowa
2013-12-18 8:40 ` Gao feng
2013-12-19 0:37 ` Hannes Frederic Sowa
2013-12-19 0:47 ` RongQing Li
2013-12-19 4:40 ` [PATCH v2] ipv6: always set the new created dst's from in ip6_rt_copy roy.qing.li
2013-12-19 12:43 ` Hannes Frederic Sowa
2013-12-19 23:36 ` David Miller
2013-12-18 7:59 ` [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AFE7E3.3070806@cn.fujitsu.com \
--to=gaofeng@cn$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roy.qing.li@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox