From: Gao feng <gaofeng@cn•fujitsu.com>
To: netdev@vger•kernel.org,
Hannes Frederic Sowa <hannes@stressinduktion•org>
Cc: RongQing Li <roy.qing.li@gmail•com>
Subject: Re: [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy
Date: Tue, 17 Dec 2013 17:23:37 +0800 [thread overview]
Message-ID: <52B01819.8030602@cn.fujitsu.com> (raw)
In-Reply-To: <20131217083048.GB18396@order.stressinduktion.org>
On 12/17/2013 04:30 PM, Hannes Frederic Sowa wrote:
> On Tue, Dec 17, 2013 at 03:46:24PM +0800, Gao feng wrote:
>>> Gao, do you still remember why you used RTF_ADDRCONF|RTF_DEFAULT?
>>>
>>
>> It's a mystery， I noticed this problem when I wrote the codes.
>> http://lists.openwall.net/netdev/2012/03/19/7
>
> I already found this thread, thanks. ;)
>
>> I used the flags RTF_ADDRCONF|RTF_DEFAULT because they are exist in
>> rt6_{get,add,purge}_dflt_router.
>
> I thought so, but we have to deal with !DEFAULT ADDRCONF routes, too.
Right.
>
>> The from of new cloned rt should not be set if it's impossible for the ort
>> to be expired.
>
> Ok.
>
>> but seems we should set from if flags have RTF_ADDRCONF bit. RA package
>> not only generate the default route.
>
> Exactly, but it is worse:
>
> Prefix routes can be added with expiration time if user space installs a
> prefix with valid_lft != infinity. So I fear we already have permament route
> entries which expire.
Yes, this should happen..
>
> Userspace router advertisment listener already use that.
>
> I fear the flags don't have a well defined semantic any more. :(
>
> As for the original patch in this thread, I would suggest to hold it
> back until this mess is understood. Ok?
>
I'm ok if we want the behave back to the commit 1716a96101[ipv6: fix problem with
expired dst cache].
next prev parent reply other threads:[~2013-12-17 9:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:31 [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy roy.qing.li
2013-12-16 13:47 ` Eric Dumazet
2013-12-17 3:25 ` Gao feng
2013-12-17 3:32 ` RongQing Li
2013-12-17 5:57 ` Gao feng
2013-12-17 6:42 ` RongQing Li
2013-12-17 7:02 ` Hannes Frederic Sowa
2013-12-17 7:46 ` Gao feng
2013-12-17 8:30 ` Hannes Frederic Sowa
2013-12-17 9:23 ` Gao feng [this message]
2013-12-17 13:48 ` Hannes Frederic Sowa
2013-12-18 0:48 ` Gao feng
2013-12-18 1:58 ` RongQing Li
2013-12-18 2:09 ` Gao feng
2013-12-18 2:21 ` RongQing Li
2013-12-18 6:20 ` Hannes Frederic Sowa
2013-12-18 8:40 ` Gao feng
2013-12-19 0:37 ` Hannes Frederic Sowa
2013-12-19 0:47 ` RongQing Li
2013-12-19 4:40 ` [PATCH v2] ipv6: always set the new created dst's from in ip6_rt_copy roy.qing.li
2013-12-19 12:43 ` Hannes Frederic Sowa
2013-12-19 23:36 ` David Miller
2013-12-18 7:59 ` [PATCH] ipv6: clear RTF_EXPIRES when call ip6_rt_copy Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B01819.8030602@cn.fujitsu.com \
--to=gaofeng@cn$(echo .)fujitsu.com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roy.qing.li@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox