From: Amir Vadai <amirv@mellanox•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Or Gerlitz <ogerlitz@mellanox•com>,
Yevgeny Petrilin <yevgenyp@mellanox•com>,
<netdev@vger•kernel.org>, Rana Shahout <ranas@mellanox•com>,
Eugenia Emantayev <eugenia@mellanox•co.il>,
Eyal Perry <eyalpe@mellanox•com>
Subject: Re: [PATCH net-next V1 10/11] net/mlx4_en: Fix Supported/Advertised link mode reported by ethtool
Date: Tue, 17 Dec 2013 19:35:45 +0200 [thread overview]
Message-ID: <52B08B71.90006@mellanox.com> (raw)
In-Reply-To: <1387295214.1799.63.camel@bwh-desktop.uk.level5networks.com>
On 17/12/2013 17:46, Ben Hutchings wrote:
>> + ADVERTISED_40000baseLR4_Full;
> [...]
>
> How is this correct? You should report the actual capabilities of the
> MAC and PHY are present, not the union of all possible modes of all the
> supported boards.
I miss-understood this field.
Will fix it.
>
> (And the Kconfig description for MLX4_EN says '10Gbit Ethernet support',
> so if this driver now supports some 40G boards that should be updated.)
Will fix it for V2
>
> Ben
Thanks,
Amir
next prev parent reply other threads:[~2013-12-17 17:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 7:01 [PATCH net-next V1 00/11] net/mlx4: Mellanox driver update 08-12-2013 Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 01/11] net/mlx4_core: Remove zeroed out of explicit QUERY_FUNC_CAP fields Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 02/11] net/mlx4_core: Rename " Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 03/11] net/mlx4_core: Introduce nic_info new flag in QUERY_FUNC_CAP Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 04/11] net/mlx4_core: Expose physical port id as PF/VF capability Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 05/11] net/mlx4_en: Implement ndo_get_phys_port_id Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 06/11] net/mlx4_en: Configure the XPS queue mapping on driver load Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 07/11] net/mlx4_core: Set CQE/EQE size to 64B by default Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 08/11] net/mlx4_en: Ignore irrelevant hypervisor events Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 09/11] net/mlx4_en: Add NAPI support for transmit side Amir Vadai
2013-12-17 7:01 ` [PATCH net-next V1 10/11] net/mlx4_en: Fix Supported/Advertised link mode reported by ethtool Amir Vadai
2013-12-17 15:46 ` Ben Hutchings
2013-12-17 17:35 ` Amir Vadai [this message]
2013-12-19 8:34 ` Amir Vadai
2013-12-19 18:55 ` David Miller
2013-12-17 7:02 ` [PATCH net-next V1 11/11] net/mlx4_core: Check port number for validity before accessing data Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B08B71.90006@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eugenia@mellanox$(echo .)co.il \
--cc=eyalpe@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=ranas@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox