From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>,
Linux Kernel Network Developers <netdev@vger•kernel.org>
Cc: "David S. Miller" <davem@davemloft•net>
Subject: Re: [Patch net-next 1/4] net_sched: act: clean up notification functions
Date: Thu, 19 Dec 2013 09:40:32 -0500 [thread overview]
Message-ID: <52B30560.4090000@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpV9Z_K7DRrYLF+hO=_nqEWYoEstuEEGunG1knXe_KB-DQ@mail.gmail.com>
On 12/18/13 19:48, Cong Wang wrote:
> On Wed, Dec 18, 2013 at 4:36 PM, Cong Wang <xiyou.wangcong@gmail•com> wrote:
>> - if (ret > 0)
>> - return 0;
>> - return ret;
>> - }
>> + else /* delete */
>> + ret = tcf_del_notify(net, n, &actions, portid);
>
> This piece doesn't look correct. :-) I will fix it.
>
It is not as trivial and i dont think you have the correct tests to
vet it.
Please give me until this weekend to test your other changes
that are already in.
I also had some changes i wanted to get in. Then I will review
and maybe test this as well...
cheers,
jamal
next prev parent reply other threads:[~2013-12-19 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 0:36 [Patch net-next 0/4] net_sched: improve tc action code Cong Wang
2013-12-19 0:36 ` [Patch net-next 1/4] net_sched: act: clean up notification functions Cong Wang
2013-12-19 0:48 ` Cong Wang
2013-12-19 14:40 ` Jamal Hadi Salim [this message]
2013-12-20 1:39 ` Cong Wang
2013-12-19 0:36 ` [Patch net-next 2/4] net_sched: act: move idx_gen to struct tcf_hashinfo Cong Wang
2013-12-19 0:36 ` [Patch net-next 3/4] net_sched: mirred: remove action when the target device is gone Cong Wang
2013-12-19 0:36 ` [Patch net-next 4/4] net_sched: mirred: notify user-space when action gets removed Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B30560.4090000@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox