From: Ding Tianhong <dingtianhong@huawei•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
Jay Vosburgh <fubar@us•ibm.com>,
Andy Gospodarek <andy@greyhouse•net>,
"David S. Miller" <davem@davemloft•net>,
Veaceslav Falico <vfalico@redhat•com>,
Netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 1/3] bonding: add option lp_interval for loading module
Date: Sat, 21 Dec 2013 14:00:57 +0800 [thread overview]
Message-ID: <52B52E99.7070809@huawei.com> (raw)
In-Reply-To: <52B44953.30703@cogentembedded.com>
On 2013/12/20 21:42, Sergei Shtylyov wrote:
> Hello.
>
> On 20-12-2013 9:10, Ding Tianhong wrote:
>
>> The bond driver could set the lp_interval when loading module.
>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei•com>
>> ---
>> drivers/net/bonding/bond_main.c | 15 +++++++++++++--
>> 1 file changed, 13 insertions(+), 2 deletions(-)
>
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index c0456cc..368f7e4 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
> [...]
>> @@ -4271,6 +4276,12 @@ static int bond_check_params(struct bond_params *params)
>> fail_over_mac_value = BOND_FOM_NONE;
>> }
>>
>> + if (lp_interval == 0) {
>> + pr_warning("Warning: ip_interval must be between 1 and %d, so it was reset to %d\n",
>> + INT_MAX, BOND_ALB_DEFAULT_LP_INTERVAL);
>
> The continuation line should be aligned under ", according to the networking coding style.
>
> WBR, Sergei
>
>
Ok, I will fix it, thanks.
Regards
Ding
>
next prev parent reply other threads:[~2013-12-21 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 5:10 [PATCH net-next 1/3] bonding: add option lp_interval for loading module Ding Tianhong
2013-12-20 13:42 ` Sergei Shtylyov
2013-12-21 6:00 ` Ding Tianhong [this message]
2013-12-21 2:04 ` Scott Feldman
2013-12-21 2:06 ` Scott Feldman
2013-12-21 6:28 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B52E99.7070809@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox