From: Ding Tianhong <dingtianhong@huawei•com>
To: Scott Feldman <sfeldma@cumulusnetworks•com>
Cc: Jay Vosburgh <fubar@us•ibm.com>,
Andy Gospodarek <andy@greyhouse•net>,
"David S. Miller" <davem@davemloft•net>,
Veaceslav Falico <vfalico@redhat•com>,
Netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 1/3] bonding: add option lp_interval for loading module
Date: Sat, 21 Dec 2013 14:28:30 +0800 [thread overview]
Message-ID: <52B5350E.7060203@huawei.com> (raw)
In-Reply-To: <469C6575-826C-4FF7-8FAE-78166EEB177B@cumulusnetworks.com>
On 2013/12/21 10:06, Scott Feldman wrote:
>
> On Dec 19, 2013, at 9:10 PM, Ding Tianhong <dingtianhong@huawei•com> wrote:
>
>> @@ -4271,6 +4276,12 @@ static int bond_check_params(struct bond_params *params)
>> fail_over_mac_value = BOND_FOM_NONE;
>> }
>>
>> + if (lp_interval == 0) {
>> + pr_warning("Warning: ip_interval must be between 1 and %d, so it was reset to %d\n",
>> + INT_MAX, BOND_ALB_DEFAULT_LP_INTERVAL);
>> + lp_interval = BOND_ALB_DEFAULT_LP_INTERVAL;
>> + }
>> +
>
> [sorry, replied with wrong email]
>
> What do you think about using the new bond_option_xxx_set() functions for module parameters also? The above code, for example, is duplicated in bond_option_lp_interval_set(). This way, we have a unified solution, where option bounds checking, compatibility, warnings, etc happened in one place for all three modes of input: sysfs, netlink, and module params.
>
> -scott
>
Yes, I agree with you, and I will wait for you to finish the bond_option_xxx_set() and then make the bond_check_params() use them, I think the code will be more simplify.
Thanks
Regards
ding
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2013-12-21 6:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 5:10 [PATCH net-next 1/3] bonding: add option lp_interval for loading module Ding Tianhong
2013-12-20 13:42 ` Sergei Shtylyov
2013-12-21 6:00 ` Ding Tianhong
2013-12-21 2:04 ` Scott Feldman
2013-12-21 2:06 ` Scott Feldman
2013-12-21 6:28 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B5350E.7060203@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@cumulusnetworks$(echo .)com \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox