From: David Vrabel <david.vrabel@citrix•com>
To: "Andrew J. Bennieston" <andrew.bennieston@citrix•com>
Cc: <xen-devel@lists•xenproject.org>, <netdev@vger•kernel.org>,
<paul.durrant@citrix•com>, <wei.liu2@citrix•com>,
<ian.campbell@citrix•com>
Subject: Re: [Xen-devel] [PATCH V3 net-next 4/5] xen-netfront: Add support for multiple queues
Date: Fri, 14 Feb 2014 18:11:45 +0000 [thread overview]
Message-ID: <52FE5C61.6000807@citrix.com> (raw)
In-Reply-To: <1392399353-11973-5-git-send-email-andrew.bennieston@citrix.com>
On 14/02/14 17:35, Andrew J. Bennieston wrote:
> From: "Andrew J. Bennieston" <andrew.bennieston@citrix•com>
>
> Build on the refactoring of the previous patch to implement multiple
> queues between xen-netfront and xen-netback.
>
> Check XenStore for multi-queue support, and set up the rings and event
> channels accordingly.
>
> Write ring references and event channels to XenStore in a queue
> hierarchy if appropriate, or flat when using only one queue.
>
> Update the xennet_select_queue() function to choose the queue on which
> to transmit a packet based on the skb hash result.
[...]
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -57,6 +57,10 @@
> #include <xen/interface/memory.h>
> #include <xen/interface/grant_table.h>
>
> +/* Module parameters */
> +unsigned int xennet_max_queues;
> +module_param(xennet_max_queues, uint, 0644);
Module parameter should have some documentation with MODULE_PARAM_DESC()
or similar.
Otherwise,
Reviewed-by: David Vrabel <david.vrabel@citrix•com>
David
next prev parent reply other threads:[~2014-02-14 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 17:35 [PATCH V3 net-next 0/5] xen-net{back, front}: Multiple transmit and receive queues Andrew J. Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 1/5] xen-netback: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 2/5] xen-netback: Add support for multiple queues Andrew J. Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 3/5] xen-netfront: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-02-14 18:04 ` [Xen-devel] " David Vrabel
2014-02-17 11:10 ` Andrew Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 4/5] xen-netfront: Add support for multiple queues Andrew J. Bennieston
2014-02-14 18:11 ` David Vrabel [this message]
2014-02-14 17:35 ` [PATCH V3 net-next 5/5] xen-net{back, front}: Document multi-queue feature in netif.h Andrew J. Bennieston
2014-02-14 18:23 ` [Xen-devel] " David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FE5C61.6000807@citrix.com \
--to=david.vrabel@citrix$(echo .)com \
--cc=andrew.bennieston@citrix$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.durrant@citrix$(echo .)com \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox