From: Alexander Duyck <alexander.h.duyck@intel•com>
To: Prarit Bhargava <prarit@redhat•com>,
David Laight <David.Laight@ACULAB•COM>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Bruce Allan <bruce.w.allan@intel•com>,
Carolyn Wyborny <carolyn.wyborny@intel•com>,
Don Skidmore <donald.c.skidmore@intel•com>,
Greg Rose <gregory.v.rose@intel•com>,
John Ronciak <john.ronciak@intel•com>,
Mitch Williams <mitch.a.williams@intel•com>,
"David S. Miller" <davem@davemloft•net>,
"nhorman@redhat•com" <nhorman@redhat•com>,
"agospoda@redhat•com" <agospoda@redhat•com>,
"e1000-devel@lists•sourceforge.net"
<e1000-devel@lists•sourceforge.net>
Subject: Re: [PATCH 0/2] ixgbe, fix numa issues
Date: Tue, 25 Feb 2014 07:10:49 -0800 [thread overview]
Message-ID: <530CB279.4010307@intel.com> (raw)
In-Reply-To: <530C77DE.8050409@redhat.com>
On 02/25/2014 03:00 AM, Prarit Bhargava wrote:
>
> On 02/25/2014 05:21 AM, David Laight wrote:
>> From: Prarit Bhargava
>> ...
>>> What has caused that check to be necessary is that the ixgbe driver is now
>>> allocating so many interrupts that on large systems which full sockets are taken
>>> in and out of service, it is possible that there are not enough empty vectors
>>> for all the irqs on a down'd cpu. IMO what the ixgbe driver is effectively
>>> doing is starving the system of resources. If I rmmod the ixgbe driver (and
>>> free it's irqs of course) I have no problem in taking all cpus except 1 out of
>>> service.
>> If I read that correctly it looks as though ixgbe should be allocating
>> a number of interrupts on each cpu - for the interrupts it wants to take
>> on that cpu.
> Yes, the code currently does it.
>
>> Then taking the cpu out of service would 'just' require that the interrupts
>> that are tied to that cpu be removed first?
> Yes, that would happen with a cpu notifier (I've already written a simple dummy
> one that just printk's when called). I started to implement a single queue
> teardown but hit some of these enumeration issues. I'd like to fix these first
> and then get to the teardown.
>
> P.
>
>
What should happen if you attempt to remove the CPU the root complex is
attached to? Will that trigger a remove via the PCIe complex being removed?
Thanks,
Alex
next prev parent reply other threads:[~2014-02-25 15:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 18:51 [PATCH 0/2] ixgbe, fix numa issues Prarit Bhargava
2014-02-24 18:51 ` [PATCH 1/2] ixgbe, make interrupt allocations NUMA aware Prarit Bhargava
2014-02-24 19:26 ` Alexander Duyck
2014-02-24 19:39 ` Prarit Bhargava
2014-02-24 19:49 ` Alexander Duyck
2014-02-24 18:51 ` [PATCH 2/2] ixgbe, don't assume mapping of numa node cpus Prarit Bhargava
2014-02-24 19:39 ` Alexander Duyck
2014-02-25 17:27 ` Amir Vadai
2014-02-25 17:43 ` Prarit Bhargava
2014-02-24 19:23 ` [PATCH 0/2] ixgbe, fix numa issues Alexander Duyck
2014-02-24 19:34 ` Prarit Bhargava
2014-02-24 19:57 ` Alexander Duyck
2014-02-25 1:06 ` Prarit Bhargava
2014-02-25 10:21 ` David Laight
2014-02-25 11:00 ` Prarit Bhargava
2014-02-25 15:10 ` Alexander Duyck [this message]
2014-02-25 15:13 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530CB279.4010307@intel.com \
--to=alexander.h.duyck@intel$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=agospoda@redhat$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=prarit@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox