From: Prarit Bhargava <prarit@redhat•com>
To: Amir Vadai <amirv@mellanox•com>
Cc: nhorman@redhat•com, idos@mellanox•com,
Yevgeny Petrilin <yevgenyp@mellanox•com>,
e1000-devel@lists•sourceforge.net, netdev@vger•kernel.org,
Bruce Allan <bruce.w.allan@intel•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
agospoda@redhat•com, John Ronciak <john.ronciak@intel•com>,
"David S. Miller" <davem@davemloft•net>,
Or Gerlitz <ogerlitz@mellanox•com>
Subject: Re: ixgbe, don't assume mapping of numa node cpus
Date: Tue, 25 Feb 2014 12:43:05 -0500 [thread overview]
Message-ID: <530CD629.2030607@redhat.com> (raw)
In-Reply-To: <20140225172726.GA31074@mtl-eit-vdi-22.mtl.labs.mlnx>
On 02/25/2014 12:27 PM, Amir Vadai wrote:
> On 24/02/14 13:51 -0500, Prarit Bhargava wrote:
>> The ixgbe driver assumes that the cpus on a node are mapped 1:1 with the
>> indexes into arrays. This is not the case as nodes can contain, for
>> example, cpus 0-7, 33-40.
>>
>> This patch fixes this problem.
>>
>> Signed-off-by: Prarit Bhargava <prarit@redhat•com>
>> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
>> Cc: Jesse Brandeburg <jesse.brandeburg@intel•com>
>> Cc: Bruce Allan <bruce.w.allan@intel•com>
>> Cc: Carolyn Wyborny <carolyn.wyborny@intel•com>
>> Cc: Don Skidmore <donald.c.skidmore@intel•com>
>> Cc: Greg Rose <gregory.v.rose@intel•com>
>> Cc: Alex Duyck <alexander.h.duyck@intel•com>
>> Cc: John Ronciak <john.ronciak@intel•com>
>> Cc: Mitch Williams <mitch.a.williams@intel•com>
>> Cc: "David S. Miller" <davem@davemloft•net>
>> Cc: nhorman@redhat•com
>> Cc: agospoda@redhat•com
>> Cc: e1000-devel@lists•sourceforge.net
>> ---
>
> Hi,
>
> I'm just about to send tomorrow a patch to add an helper function to
> get affinity_hint suggestion by numa_node and ring index.
> If you'd like you will be able to use it too here.
>
> We're still doing internal review on it before sending to the mailing
> list, but this will be the declaration of the function:
> /*
> * netif_set_rx_queue_affinity_hint - set affinity hint of rx queue
> * @rxq: index of rx queue
> * @numa_node: prefered numa_node
> * @affinity_mask: the relevant cpu bit is set according to the policy
> *
> * This function sets the affinity_mask according to a numa aware policy.
> * affinity_mask coulbe used as an affinity hint for the IRQ related of this
> * rx queue.
> * The policy is to spread rx queues across cores - local cores first.
> *
> * Returns 0 on success, or a negative error code.
> */
> int netif_set_rx_queue_affinity_hint(int rxq, int numa_node,
> cpumask_var_t affinity_mask);
I'm going to wait for this patch then. Amir, please cc me.
Thanks for the info,
P.
>
>
>
> Amir
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2014-02-25 17:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 18:51 [PATCH 0/2] ixgbe, fix numa issues Prarit Bhargava
2014-02-24 18:51 ` [PATCH 1/2] ixgbe, make interrupt allocations NUMA aware Prarit Bhargava
2014-02-24 19:26 ` Alexander Duyck
2014-02-24 19:39 ` Prarit Bhargava
2014-02-24 19:49 ` Alexander Duyck
2014-02-24 18:51 ` [PATCH 2/2] ixgbe, don't assume mapping of numa node cpus Prarit Bhargava
2014-02-24 19:39 ` Alexander Duyck
2014-02-25 17:27 ` Amir Vadai
2014-02-25 17:43 ` Prarit Bhargava [this message]
2014-02-24 19:23 ` [PATCH 0/2] ixgbe, fix numa issues Alexander Duyck
2014-02-24 19:34 ` Prarit Bhargava
2014-02-24 19:57 ` Alexander Duyck
2014-02-25 1:06 ` Prarit Bhargava
2014-02-25 10:21 ` David Laight
2014-02-25 11:00 ` Prarit Bhargava
2014-02-25 15:10 ` Alexander Duyck
2014-02-25 15:13 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530CD629.2030607@redhat.com \
--to=prarit@redhat$(echo .)com \
--cc=agospoda@redhat$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=idos@mellanox$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox