From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Hariprasad Shenai <hariprasad@chelsio•com>,
netdev@vger•kernel.org, linux-rdma@vger•kernel.org
Cc: davem@davemloft•net, roland@purestorage•com, kumaras@chelsio•com,
dm@chelsio•com, swise@opengridcomputing•com, leedom@chelsio•com,
santosh@chelsio•com, nirranjan@chelsio•com
Subject: Re: [PATCHv2 net-next 29/31] iw_cxgb4: minor fixes/cleanup.
Date: Mon, 03 Mar 2014 21:55:13 +0300 [thread overview]
Message-ID: <5314D011.7090104@cogentembedded.com> (raw)
In-Reply-To: <1393828875-13452-30-git-send-email-hariprasad@chelsio.com>
Hello.
On 03/03/2014 09:41 AM, Hariprasad Shenai wrote:
> From: Steve Wise <swise@opengridcomputing•com>
> Added some missing debug stats.
> Use uninitialized_var().
> Rate limit warning printks.
Wasn't it already rate-limited?
> Initialize reserved fields in a FW work request.
I don't think it's a great idea to mix several fixes and worse, cleanups
in the same patch.
> Signed-off-by: Steve Wise <swise@opengridcomputing•com>
[...]
> diff --git a/drivers/infiniband/hw/cxgb4/resource.c b/drivers/infiniband/hw/cxgb4/resource.c
> index cdef4d7..69e57d0 100644
> --- a/drivers/infiniband/hw/cxgb4/resource.c
> +++ b/drivers/infiniband/hw/cxgb4/resource.c
[...]
> @@ -322,8 +326,8 @@ u32 c4iw_rqtpool_alloc(struct c4iw_rdev *rdev, int size)
> unsigned long addr = gen_pool_alloc(rdev->rqt_pool, size << 6);
> PDBG("%s addr 0x%x size %d\n", __func__, (u32)addr, size << 6);
> if (!addr)
> - printk_ratelimited(KERN_WARNING MOD "%s: Out of RQT memory\n",
> - pci_name(rdev->lldi.pdev));
> + pr_warn_ratelimited(KERN_WARNING MOD "%s: Out of RQT memory\n",
You forgot to remove KERN_WARNING.
WBR, Sergei
next prev parent reply other threads:[~2014-03-03 17:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 6:40 [PATCHv2 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4 Hariprasad Shenai
[not found] ` <1393828875-13452-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-03 6:40 ` [PATCHv2 net-next 01/31] cxgb4: Fix some small bugs in t4_sge_init_soft() when our Page Size is 64KB Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 02/31] cxgb4: Add code to dump SGE registers when hitting idma hangs Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 04/31] cxgb4: Updates for T5 SGE's Egress Congestion Threshold Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 08/31] iw_cxgb4: release neigh entry in error paths Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 12/31] iw_cxgb4: Fix incorrect BUG_ON conditions Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 15/31] iw_cxgb4: save the correct map length for fast_reg_page_lists Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 22/31] iw_cxgb4: lock around accept/reject downcalls Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 24/31] iw_cxgb4: rx_data() needs to hold the ep mutex Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 28/31] iw_cxgb4: SQ flush fix Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 05/31] cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 06/31] iw_cxgb4: cap CQ size at T4_MAX_IQ_SIZE Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 07/31] iw_cxgb4: Allow loopback connections Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 09/31] iw_cxgb4: Treat CPL_ERR_KEEPALV_NEG_ADVICE as negative advice Hariprasad Shenai
2014-03-03 18:44 ` Sergei Shtylyov
2014-03-03 6:40 ` [PATCHv2 net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 11/31] iw_cxgb4: use the BAR2/WC path for kernel QPs and T5 devices Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 13/31] iw_cxgb4: Mind the sq_sig_all/sq_sig_type QP attributes Hariprasad Shenai
2014-03-03 6:40 ` [PATCHv2 net-next 14/31] iw_cxgb4: default peer2peer mode to 1 Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 16/31] iw_cxgb4: don't leak skb in c4iw_uld_rx_handler() Hariprasad Shenai
[not found] ` <1393828875-13452-17-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-03 18:46 ` Sergei Shtylyov
2014-03-03 6:41 ` [PATCHv2 net-next 17/31] iw_cxgb4: fix possible memory leak in RX_PKT processing Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 18/31] iw_cxgb4: ignore read reponse type 1 CQEs Hariprasad Shenai
2014-03-03 18:49 ` Sergei Shtylyov
2014-03-03 6:41 ` [PATCHv2 net-next 19/31] iw_cxgb4: connect_request_upcall fixes Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window based on link speed Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 21/31] iw_cxgb4: update snd_seq when sending MPA messages Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 23/31] iw_cxgb4: drop RX_DATA packets if the endpoint is gone Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 25/31] iw_cxgb4: endpoint timeout fixes Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 26/31] iw_cxgb4: rmb() after reading valid gen bit Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 27/31] iw_cxgb4: wc_wmb() needed after DB writes Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 29/31] iw_cxgb4: minor fixes/cleanup Hariprasad Shenai
2014-03-03 18:55 ` Sergei Shtylyov [this message]
2014-03-03 6:41 ` [PATCHv2 net-next 30/31] iw_cxgb4: Max fastreg depth depends on DSGL support Hariprasad Shenai
2014-03-03 6:41 ` [PATCHv2 net-next 31/31] Revert "cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit()" Hariprasad Shenai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314D011.7090104@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dm@chelsio$(echo .)com \
--cc=hariprasad@chelsio$(echo .)com \
--cc=kumaras@chelsio$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nirranjan@chelsio$(echo .)com \
--cc=roland@purestorage$(echo .)com \
--cc=santosh@chelsio$(echo .)com \
--cc=swise@opengridcomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox