From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public•gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public•gmane.org>,
Hariprasad Shenai
<hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
roland-BHEL68pLQRGGvPXPguhicg@public•gmane.org,
kumaras-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org,
dm-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public•gmane.org,
leedom-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org,
santosh-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org,
nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org
Subject: Re: [PATCHv3 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck
Date: Tue, 04 Mar 2014 23:22:12 +0300 [thread overview]
Message-ID: <531635F4.9050208@cogentembedded.com> (raw)
In-Reply-To: <1393955035.20435.40.camel@joe-AO722>
Hello.
On 03/04/2014 08:43 PM, Joe Perches wrote:
>> From: Kumar Sanghvi <kumaras-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>
>> Based on original work by Casey Leedom <leedom-ut6Up61K2wZBDgjK7y7TUQ@public•gmane.org>
> trivial comments:
>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
>> @@ -2031,21 +2041,65 @@ static void sge_rx_timer_cb(unsigned long data)
> []
>> + if (idma_same_state_cnt[i] < s->idma_1s_thresh) {
>> + if (s->idma_stalled[i] >= SGE_IDMA_WARN_THRESH)
>> + CH_WARN(adap, "SGE idma%d, queue%u,resumed after %d sec",
> Missing terminating '\n', probably better as:
> CH_WARN(adap, "SGE idma%d, queue%u, resumed after %d sec\n",
>> + CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs"
>> + " (debug0=%#x, debug11=%#x)\n",
> Probably better with the format coalesced:
> CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs (debug0=%#x, debug11=%#x)\n",
Surely better, as otherwise it shouldn't pass scripts/checkpatch.pl.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-04 20:22 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 12:41 [PATCHv3 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4 Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 04/31] cxgb4: Updates for T5 SGE's Egress Congestion Threshold Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 05/31] cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 06/31] iw_cxgb4: cap CQ size at T4_MAX_IQ_SIZE Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 09/31] iw_cxgb4: Treat CPL_ERR_KEEPALV_NEG_ADVICE as negative advice Hariprasad Shenai
2014-03-04 17:48 ` Sergei Shtylyov
2014-03-04 12:41 ` [PATCHv3 net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 11/31] iw_cxgb4: use the BAR2/WC path for kernel QPs and T5 devices Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 12/31] iw_cxgb4: Fix incorrect BUG_ON conditions Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 14/31] iw_cxgb4: default peer2peer mode to 1 Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 15/31] iw_cxgb4: save the correct map length for fast_reg_page_lists Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 17/31] iw_cxgb4: fix possible memory leak in RX_PKT processing Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 18/31] iw_cxgb4: ignore read reponse type 1 CQEs Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 19/31] iw_cxgb4: connect_request_upcall fixes Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window based on link speed Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 21/31] iw_cxgb4: update snd_seq when sending MPA messages Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 22/31] iw_cxgb4: lock around accept/reject downcalls Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 23/31] iw_cxgb4: drop RX_DATA packets if the endpoint is gone Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 24/31] iw_cxgb4: rx_data() needs to hold the ep mutex Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 25/31] iw_cxgb4: endpoint timeout fixes Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 26/31] iw_cxgb4: rmb() after reading valid gen bit Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 27/31] iw_cxgb4: wc_wmb() needed after DB writes Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 29/31] iw_cxgb4: minor fixes Hariprasad Shenai
[not found] ` <1393936917-25847-30-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-04 17:43 ` Sergei Shtylyov
2014-03-04 12:41 ` [PATCHv3 net-next 30/31] iw_cxgb4: Max fastreg depth depends on DSGL support Hariprasad Shenai
[not found] ` <1393936917-25847-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-04 12:41 ` [PATCHv3 net-next 01/31] cxgb4: Fix some small bugs in t4_sge_init_soft() when our Page Size is 64KB Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 02/31] cxgb4: Add code to dump SGE registers when hitting idma hangs Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck Hariprasad Shenai
2014-03-04 17:43 ` Joe Perches
2014-03-04 20:22 ` Sergei Shtylyov [this message]
[not found] ` <531635F4.9050208-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-03-04 19:36 ` [PATCH net-next] chelsio: Use more current logging style Joe Perches
2014-03-06 6:20 ` Hariprasad S
2014-03-06 9:39 ` Joe Perches
2014-03-06 17:48 ` David Miller
2014-03-04 12:41 ` [PATCHv3 net-next 07/31] iw_cxgb4: Allow loopback connections Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 08/31] iw_cxgb4: release neigh entry in error paths Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 13/31] iw_cxgb4: Mind the sq_sig_all/sq_sig_type QP attributes Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 16/31] iw_cxgb4: don't leak skb in c4iw_uld_rx_handler() Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 28/31] iw_cxgb4: SQ flush fix Hariprasad Shenai
2014-03-04 12:41 ` [PATCHv3 net-next 31/31] Revert "cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit()" Hariprasad Shenai
2014-03-04 18:22 ` [PATCHv3 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4 David Miller
[not found] ` <20140304.132226.75524344104026791.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-05 5:30 ` Hariprasad S
2014-03-05 19:15 ` Casey Leedom
[not found] ` <9E6E5D92-7F25-49A3-BEB5-424CCE2F725D-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-05 19:39 ` Or Gerlitz
[not found] ` <CAJZOPZL05TY6qSdBDoS6aCj=_uepkZTX5+fVvnHTsCsKKMqgSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-05 19:46 ` Casey Leedom
[not found] ` <F598A76E-C6C1-4183-B4B9-DF78FD1FE73A-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-05 19:52 ` Or Gerlitz
[not found] ` <CAJZOPZL6U7csoTvF8wzJBK+Whknv4dqNbkO8nC=LrXoUMXhoUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-05 19:59 ` Casey Leedom
[not found] ` <DB7B3A5C-9674-44C2-8AA4-2C468F09DFF5-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-05 20:51 ` Casey Leedom
2014-03-05 23:58 ` Steve Wise
2014-03-07 6:17 ` Hariprasad S
2014-03-05 11:30 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531635F4.9050208@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dm-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=kumaras-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=leedom-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public$(echo .)gmane.org \
--cc=santosh-ut6Up61K2wZBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox