From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: "Keller, Jacob E" <jacob.e.keller@intel•com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>,
"sassmann@redhat•com" <sassmann@redhat•com>
Subject: Re: [net-next 12/13] ixgbe: fix some multiline hw_dbg prints
Date: Wed, 12 Mar 2014 23:24:03 +0300 [thread overview]
Message-ID: <5320C263.9000105@cogentembedded.com> (raw)
In-Reply-To: <5320BF63.30403@cogentembedded.com>
On 03/12/2014 11:11 PM, Sergei Shtylyov wrote:
>>>> From: Jacob Keller <jacob.e.keller@intel•com>
>>>> This patch fixes some formatting on multilined print messages, so that
>>>> the text of the print appears on a single line, which aids in grepping
>>>> the sourcecode for where the error came from.
>>>> Signed-off-by: Jacob Keller <jacob.e.keller@intel•com>
>>>> Tested-by: Phil Schmitt <phillip.j.schmitt@intel•com>
>>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
>>>> ---
>>>> drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 8 +++-----
>>>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> index 446df3c..3bc9b67 100644
>>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> @@ -512,7 +512,7 @@ out:
>>>> *
>>>> * Disables link, should be called during D3 power down sequence.
>>>> *
>>>> - */
>>>> + **/
>>> Hm? What's this for?
>> The extra **/ is part of the standard doc format for function headers,
> It is not. Reread Documentation/kernel-doc-nano-HOWTO.txt please.
Sorry, I messed it myself -- it seems to be an optional part of the format
which I've never seen actually used. Anyway, you shouldn't do "drove-by"
changes like that, moreover undocumented in the change log.
WBR, Sergei
next prev parent reply other threads:[~2014-03-12 19:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 5:53 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-03-12 5:53 ` [net-next 01/13] net: e1000e calls skb_set_hash Jeff Kirsher
2014-03-12 5:53 ` [net-next 02/13] net: igb " Jeff Kirsher
2014-03-12 5:53 ` [net-next 03/13] igb: Fix for devices using ethtool for EEE settings Jeff Kirsher
2014-03-12 5:53 ` [net-next 04/13] igb: Add debugfs skeleton Jeff Kirsher
2014-03-12 5:53 ` [net-next 05/13] igb: Add support for debugfs Jeff Kirsher
2014-03-12 15:57 ` Or Gerlitz
2014-03-12 16:35 ` Wyborny, Carolyn
2014-03-12 19:46 ` David Miller
2014-03-12 20:13 ` Wyborny, Carolyn
2014-03-12 20:24 ` David Miller
2014-03-12 20:31 ` Wyborny, Carolyn
2014-03-12 5:53 ` [net-next 06/13] igb: Add debugfs command/register read and write functionality Jeff Kirsher
2014-03-12 5:53 ` [net-next 07/13] net: ixgbe calls skb_set_hash Jeff Kirsher
2014-03-12 5:53 ` [net-next 08/13] ixgbe: Fix format string in ixgbe_fcoe.c Jeff Kirsher
2014-03-12 5:53 ` [net-next 09/13] ixgbe: move setting rx_pb_size into get_invariants Jeff Kirsher
2014-03-12 5:53 ` [net-next 10/13] ixgbe: add Linux NICS mailing list to contact info Jeff Kirsher
2014-03-12 5:53 ` [net-next 11/13] ixgbe: fixup header for ixgbe_set_rxpba_82598 Jeff Kirsher
2014-03-12 5:53 ` [net-next 12/13] ixgbe: fix some multiline hw_dbg prints Jeff Kirsher
2014-03-12 14:51 ` Sergei Shtylyov
2014-03-12 18:31 ` Keller, Jacob E
2014-03-12 20:11 ` Sergei Shtylyov
2014-03-12 20:24 ` Sergei Shtylyov [this message]
2014-03-12 20:21 ` Keller, Jacob E
2014-03-12 5:53 ` [net-next 13/13] ixgbevf: delete unneeded call to pci_set_power_state Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320C263.9000105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox