From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
Cc: Rob Herring <robherring2@gmail•com>,
Rob Herring <robh+dt@kernel•org>,
Florian Fainelli <f.fainelli@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing
Date: Thu, 20 Mar 2014 02:53:19 +0300 [thread overview]
Message-ID: <532A2DEF.9040101@cogentembedded.com> (raw)
In-Reply-To: <20140319223633.GC1154@obsidianresearch.com>
On 03/20/2014 01:36 AM, Jason Gunthorpe wrote:
>>>> The preferred multi-line comment style is:
>>>> /*
>>>> * bla
>>>> * bla
>>>> */
>>> Sergei, the entire file use the 'net' multi-line commenting style, and
>>> I have maintined that consistency with the new code.
>> No, you haven't followed the networking style. It is:
>> /* bla
>> * bla
>> */
>> while your comment used:
>> /* bla
>> * bla */
> Oh Ok - but the latter is the used by the majority of pre-existing
> comments..
> I thought the convention on stuff like this was to stick with the
> existing style?
Hardly so when there's preferred one, described in CodingStyle.
> Do you think it is worth a v4? If so, which style is appropriate?
> There is one other pre-existing comment that uses net.
Well, use the net style then. I don't see significant difference between
it and the "default" preferred style.
> Regards,
> Jason
WBR, Sergei
next prev parent reply other threads:[~2014-03-19 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 21:05 [PATCH v2 RESEND 1/2] dt: Document a compatible entry for MDIO ethernet Phys Jason Gunthorpe
2014-03-12 21:05 ` [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing Jason Gunthorpe
2014-03-12 21:35 ` Rob Herring
2014-03-12 22:06 ` Florian Fainelli
2014-03-19 22:14 ` Jason Gunthorpe
2014-03-19 23:20 ` Sergei Shtylyov
2014-03-19 22:36 ` Jason Gunthorpe
2014-03-19 23:53 ` Sergei Shtylyov [this message]
2014-03-12 22:46 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A2DEF.9040101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jgunthorpe@obsidianresearch$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
--cc=robherring2@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox