From: Daniel Borkmann <dborkman@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>, Xi Wang <xii@google•com>
Subject: Re: [PATCH] packet: fix potential use after free
Date: Thu, 10 Apr 2014 10:19:21 +0200 [thread overview]
Message-ID: <53465409.3070507@redhat.com> (raw)
In-Reply-To: <1397092959.16584.26.camel@edumazet-glaptop2.roam.corp.google.com>
On 04/10/2014 03:22 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> As soon skb is queued into sk_receive_queue, it can be consumed,
> so its racy to access skb->len.
>
> Given that sk_data_ready() / sock_def_readable() don't really care, just
> use 0 instead of skb->len
>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Cc: Xi Wang <xii@google•com>
Acked-by: Daniel Borkmann <dborkman@redhat•com>
Seems to be there since pre 2005 ...
next prev parent reply other threads:[~2014-04-10 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 1:22 [PATCH] packet: fix potential use after free Eric Dumazet
2014-04-10 8:19 ` Daniel Borkmann [this message]
2014-04-10 15:06 ` Eric Dumazet
2014-04-11 19:59 ` David Miller
2014-04-11 23:37 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53465409.3070507@redhat.com \
--to=dborkman@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xii@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox