From: Daniel Borkmann <dborkman@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: eric.dumazet@gmail•com, netdev@vger•kernel.org, xii@google•com
Subject: Re: [PATCH] packet: fix potential use after free
Date: Sat, 12 Apr 2014 01:37:30 +0200 [thread overview]
Message-ID: <53487CBA.7080009@redhat.com> (raw)
In-Reply-To: <20140411.155922.2269056965511687739.davem@davemloft.net>
On 04/11/2014 09:59 PM, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail•com>
> Date: Thu, 10 Apr 2014 08:06:58 -0700
>
>> On Thu, 2014-04-10 at 10:19 +0200, Daniel Borkmann wrote:
>>> On 04/10/2014 03:22 AM, Eric Dumazet wrote:
>>>> From: Eric Dumazet <edumazet@google•com>
>>>>
>>>> As soon skb is queued into sk_receive_queue, it can be consumed,
>>>> so its racy to access skb->len.
>>>>
>>>> Given that sk_data_ready() / sock_def_readable() don't really care, just
>>>> use 0 instead of skb->len
>>>>
>>>> Signed-off-by: Eric Dumazet <edumazet@google•com>
>>>> Cc: Xi Wang <xii@google•com>
>>>
>>> Acked-by: Daniel Borkmann <dborkman@redhat•com>
>>>
>>> Seems to be there since pre 2005 ...
>>
>> Yeah, and many other places have the same error, a full audit is
>> probably needed.
>
> Not only sock_def_readable(), but all implementations of this callback absolutely
> do not care about the length argument.
>
> I'm working on a patch to kill the argument completely.
Sounds good! Seen you've already pushed that, thanks!
prev parent reply other threads:[~2014-04-11 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 1:22 [PATCH] packet: fix potential use after free Eric Dumazet
2014-04-10 8:19 ` Daniel Borkmann
2014-04-10 15:06 ` Eric Dumazet
2014-04-11 19:59 ` David Miller
2014-04-11 23:37 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53487CBA.7080009@redhat.com \
--to=dborkman@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xii@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox