From: Alexander Varnin <fenixk19@mail•ru>
To: netdev@vger•kernel.org
Subject: ax88796 driver
Date: Thu, 17 Apr 2014 03:42:08 +0400 [thread overview]
Message-ID: <534F1550.50704@mail.ru> (raw)
Hello!
I am currently working on kernel and dealing with ax88796 driver, that has been written by Ben Dooks <ben@simtec•co.uk>. Since his address is not available anymore (says "Ben doesn't work here any more"), I want to ask help from somebody, who maybe somehow related to this driver.
I want to ask on source code, because there is some non-obvious lines.
Take a look on ax_initial_check function from ax88796.c please [1].
Here is lines 127-129 of it:
ei_outb (E8390_NODMA + E8390_PAGE1 + E8390_STOP, ioaddr + E8390_CMD);
regd = ei_inb (ioaddr + 0x0d);
ei_outb (0xff, ioaddr + 0x0d);
This is supposed to be read and write to 0xD register on PAGE 1 of AX88796. But that offset stands for "Multicast Address Register 5 ( MAR5 )" in AX88796 datasheet [2].
What is the point of doing so? That looks very like a mistake. If it is a mistake, I could make and send patch to fix it. But, please, explain why is it done?
[1] http://lxr.free-electrons.com/source/drivers/net/ethernet/8390/ax88796.c#L116
[2] http://www.digchip.com/datasheets/parts/datasheet/562/AX88796-pdf.php
--
Alexander.
next reply other threads:[~2014-04-16 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 23:42 Alexander Varnin [this message]
2014-04-22 1:59 ` ax88796 driver Ben Hutchings
2014-04-23 13:05 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534F1550.50704@mail.ru \
--to=fenixk19@mail$(echo .)ru \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox