From: Ben Dooks <ben.dooks@codethink•co.uk>
To: Ben Hutchings <ben@decadent•org.uk>, Alexander Varnin <fenixk19@mail•ru>
Cc: netdev@vger•kernel.org, Ben Dooks <ben-linux@fluff•org>
Subject: Re: ax88796 driver
Date: Wed, 23 Apr 2014 14:05:13 +0100 [thread overview]
Message-ID: <5357BA89.4070503@codethink.co.uk> (raw)
In-Reply-To: <1398131999.3624.167.camel@deadeye.wl.decadent.org.uk>
On 22/04/14 02:59, Ben Hutchings wrote:
> On Thu, 2014-04-17 at 03:42 +0400, Alexander Varnin wrote:
>> Hello!
>>
>> I am currently working on kernel and dealing with ax88796 driver, that
>> has been written by Ben Dooks <ben@simtec•co.uk>. Since his address is
>> not available anymore (says "Ben doesn't work here any more"), I want
>> to ask help from somebody, who maybe somehow related to this driver.
>
> I'm cc'ing Ben, but I doubt he'll want to remember this driver.
>
> Ben.
Hi, I really do not remember this driver as we only used this device
on a couple of projects before changing to another supplier.
>> I want to ask on source code, because there is some non-obvious lines.
>>
>> Take a look on ax_initial_check function from ax88796.c please [1].
>>
>> Here is lines 127-129 of it:
>>
>> ei_outb (E8390_NODMA + E8390_PAGE1 + E8390_STOP, ioaddr + E8390_CMD);
>> regd = ei_inb (ioaddr + 0x0d);
>> ei_outb (0xff, ioaddr + 0x0d);
>>
>> This is supposed to be read and write to 0xD register on PAGE 1 of
>> AX88796. But that offset stands for "Multicast Address Register 5
>> ( MAR5 )" in AX88796 datasheet [2].
>>
>> What is the point of doing so? That looks very like a mistake. If it
>> is a mistake, I could make and send patch to fix it. But, please,
>> explain why is it done?
>>
>>
>> [1] http://lxr.free-electrons.com/source/drivers/net/ethernet/8390/ax88796.c#L116
>> [2] http://www.digchip.com/datasheets/parts/datasheet/562/AX88796-pdf.php
Hmm, is there an actual bug here or is this something that
we think is wrong? I could have a look but I do not have any
bootable test hardware available.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-04-23 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 23:42 ax88796 driver Alexander Varnin
2014-04-22 1:59 ` Ben Hutchings
2014-04-23 13:05 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357BA89.4070503@codethink.co.uk \
--to=ben.dooks@codethink$(echo .)co.uk \
--cc=ben-linux@fluff$(echo .)org \
--cc=ben@decadent$(echo .)org.uk \
--cc=fenixk19@mail$(echo .)ru \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox